This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 225
Ported KafkaSource to bindings api #1037
Merged
knative-prow-robot
merged 5 commits into
knative:master
from
slinkydeveloper:kafka_source_bindings_api
Mar 18, 2020
Merged
Ported KafkaSource to bindings api #1037
knative-prow-robot
merged 5 commits into
knative:master
from
slinkydeveloper:kafka_source_bindings_api
Mar 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Mar 18, 2020
mattmoor
reviewed
Mar 18, 2020
/hold |
knative-prow-robot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Mar 18, 2020
/unhold This is ready for me |
knative-prow-robot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Mar 18, 2020
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
slinkydeveloper
force-pushed
the
kafka_source_bindings_api
branch
from
March 18, 2020 13:37
42d3b1e
to
89351e7
Compare
The following is the coverage report on the affected files.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n3wscott, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #975
Performance improvements
Master:
This PR:
Around 3x less memory and 4.5x less CPU
Release Note