Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

use MT Broker for tests #1279

Merged
merged 1 commit into from
May 27, 2020
Merged

use MT Broker for tests #1279

merged 1 commit into from
May 27, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented May 27, 2020

Addresses knative/eventing#3139

Proposed Changes

  • Use MT Channel Based Broker for tests since ChannelBasedBroker is being removed.

Release Note

- 🧽 Update or clean up current behavior
Use MT Channel Based Broker for testing.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 27, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/test-and-release labels May 27, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@n3wscott
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 1f30240 into knative:master May 27, 2020
@vaikas vaikas deleted the remove-channel-based-broker branch May 27, 2020 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chizhg chizhg Awaiting requested review from chizhg

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vaikas @n3wscott @knative-prow-robot @googlebot