Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

CAMEL-14575, time pattern dropped in Camel 3.2 #1324

Merged
merged 1 commit into from
Jun 19, 2020
Merged

CAMEL-14575, time pattern dropped in Camel 3.2 #1324

merged 1 commit into from
Jun 19, 2020

Conversation

maschmid
Copy link
Contributor

time pattern has been dropped in Camel 3.2, see https://issues.apache.org/jira/browse/CAMEL-14575

Proposed Changes

  • make TestCamelSource work with Camel 3.2 by not using the obsolete time pattern

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 17, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2020
@knative-prow-robot knative-prow-robot added area/test-and-release needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2020
@knative-prow-robot
Copy link
Contributor

Hi @maschmid. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2020
matzew
matzew reviewed Jun 18, 2020
View reviewed changes
test/e2e/camel_source_test.go
@@ -66,7 +66,7 @@ func TestCamelSource(t *testing.T) {
Source: v1alpha1.CamelSourceOriginSpec{
Flow: &v1alpha1.Flow{
"from": &map[string]interface{}{
"uri": "timer:tick?period=1s",
"uri": "timer:tick?period=1000",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolaferraro can you take a looksie ?

/lgtm ;-)

@matzew
Copy link
Member

matzew commented Jun 18, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
nicolaferraro
nicolaferraro approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolaferraro
Copy link
Contributor

/lgtm

@matzew
Copy link
Member

matzew commented Jun 19, 2020

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid, matzew, nicolaferraro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@knative-prow-robot knative-prow-robot merged commit ee389d0 into knative:master Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matzew matzew matzew left review comments

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@chizhg chizhg Awaiting requested review from chizhg

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@matzew matzew

@nicolaferraro nicolaferraro

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maschmid @knative-prow-robot @pierDipi @matzew @nicolaferraro @googlebot