Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

fix custom consumer group error channel lifecycle (#263) #1676

Merged

Conversation

lionelvillard
Copy link
Member

Backport knative-extensions/eventing-kafka#263

Proposed Changes

  • fix custom consumer group error channel lifecycle

Release Note

 🐛 Fix crash in Kafka consumer when a rebalance occurs

Docs

* fix custom consumer group error channel lifecycle

* fix import

* remove unused var
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 8, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 8, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
kafka/common/pkg/kafka/consumer_factory.go Do not exist 81.8%
kafka/common/pkg/kafka/consumer_handler.go Do not exist 89.5%

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 2d44c08 into knative:release-0.18 Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants