Skip to content

WIP: IntegrationSource CRD #6823

WIP: IntegrationSource CRD

WIP: IntegrationSource CRD #6823

Triggered via pull request October 11, 2024 07:25
Status Failure
Total duration 2m 20s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
3s
style / changes
style  /  ...  /  Auto-format and Check
21s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
1m 57s
style / Golang / Lint
style  /  ...  /  Do Not Submit
7s
style / Golang / Do Not Submit
style  /  ...  /  shell
13s
style / suggester / shell
style  /  ...  /  yaml
18s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

25 errors and 6 warnings
style / Golang / Boilerplate Check (go): pkg/reconciler/integrationsource/integrationsource.go#L1
[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/reconciler/integrationsource/integrationsource.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */
style / Golang / Boilerplate Check (go): pkg/reconciler/integrationsource/resources/containersource.go#L1
[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/reconciler/integrationsource/resources/containersource.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */
style / Golang / Boilerplate Check (go): pkg/reconciler/integrationsource/resources/labels.go#L8
[Go headers] reported by reviewdog 🐶 found mismatched boilerplate lines: Raw Output: pkg/reconciler/integrationsource/resources/labels.go:8: found mismatched boilerplate lines: {[]string}[0]: -: "\thttp://www.apache.org/licenses/LICENSE-2.0" +: " http://www.apache.org/licenses/LICENSE-2.0"
style / Golang / Boilerplate Check (go)
Process completed with exit code 1.
style / suggester / yaml
Process completed with exit code 1.
style / Golang / Auto-format and Check: cmd/webhook/main.go#L1
Please run goimports. diff --git a/cmd/webhook/main.go b/cmd/webhook/main.go index 68d4777..1f504c5 100644 --- a/cmd/webhook/main.go +++ b/cmd/webhook/main.go @@ -18,9 +18,10 @@ package main import ( "context" - sourcesv1alpha1 "knative.dev/eventing/pkg/apis/sources/v1alpha1" "os" + sourcesv1alpha1 "knative.dev/eventing/pkg/apis/sources/v1alpha1" + "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/types" "k8s.io/client-go/kubernetes/scheme"
style / Golang / Auto-format and Check: pkg/apis/sources/v1alpha1/integration_conversion.go#L1
Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_conversion.go b/pkg/apis/sources/v1alpha1/integration_conversion.go index 6b0235d..32bfc7c 100644 --- a/pkg/apis/sources/v1alpha1/integration_conversion.go +++ b/pkg/apis/sources/v1alpha1/integration_conversion.go @@ -19,6 +19,7 @@ package v1alpha1 import ( "context" "fmt" + "knative.dev/pkg/apis" )
style / Golang / Auto-format and Check: pkg/apis/sources/v1alpha1/integration_conversion_test.go#L1
Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_conversion_test.go b/pkg/apis/sources/v1alpha1/integration_conversion_test.go index 93d712e..2272ecc 100644 --- a/pkg/apis/sources/v1alpha1/integration_conversion_test.go +++ b/pkg/apis/sources/v1alpha1/integration_conversion_test.go @@ -19,8 +19,9 @@ package v1alpha1 import ( "context" "errors" - "knative.dev/pkg/apis" "testing" + + "knative.dev/pkg/apis" ) // implement apis.Convertible
style / Golang / Auto-format and Check: pkg/apis/sources/v1alpha1/integration_defaults_test.go#L1
Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_defaults_test.go b/pkg/apis/sources/v1alpha1/integration_defaults_test.go index 3497c91..ed58649 100644 --- a/pkg/apis/sources/v1alpha1/integration_defaults_test.go +++ b/pkg/apis/sources/v1alpha1/integration_defaults_test.go @@ -18,8 +18,9 @@ package v1alpha1 import ( "context" - "github.com/google/go-cmp/cmp" "testing" + + "github.com/google/go-cmp/cmp" ) func TestSetDefaults(t *testing.T) {
style / Golang / Auto-format and Check: pkg/apis/sources/v1alpha1/integration_lifecycle_test.go#L1
Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_lifecycle_test.go b/pkg/apis/sources/v1alpha1/integration_lifecycle_test.go index 1b88bf1..26b2a00 100644 --- a/pkg/apis/sources/v1alpha1/integration_lifecycle_test.go +++ b/pkg/apis/sources/v1alpha1/integration_lifecycle_test.go @@ -17,13 +17,14 @@ limitations under the License. package v1alpha1 import ( + "testing" + "github.com/google/go-cmp/cmp" "github.com/google/go-cmp/cmp/cmpopts" corev1 "k8s.io/api/core/v1" v1 "knative.dev/eventing/pkg/apis/sources/v1" "knative.dev/pkg/apis" duckv1 "knative.dev/pkg/apis/duck/v1" - "testing" ) var (
style / Golang / Auto-format and Check: pkg/apis/sources/v1alpha1/integration_validation.go#L1
Please run goimports. diff --git a/pkg/apis/sources/v1alpha1/integration_validation.go b/pkg/apis/sources/v1alpha1/integration_validation.go index 5d2a28e..4df223e 100644 --- a/pkg/apis/sources/v1alpha1/integration_validation.go +++ b/pkg/apis/sources/v1alpha1/integration_validation.go @@ -18,6 +18,7 @@ package v1alpha1 import ( "context" + "knative.dev/pkg/apis" )
style / Golang / Auto-format and Check: pkg/reconciler/integrationsource/controller.go#L1
Please run goimports. diff --git a/pkg/reconciler/integrationsource/controller.go b/pkg/reconciler/integrationsource/controller.go index 632c40b..4fa32e2 100644 --- a/pkg/reconciler/integrationsource/controller.go +++ b/pkg/reconciler/integrationsource/controller.go @@ -18,6 +18,7 @@ package integrationsource import ( "context" + "k8s.io/apimachinery/pkg/labels" "k8s.io/apimachinery/pkg/types" "k8s.io/client-go/tools/cache"
style / Golang / Auto-format and Check: pkg/reconciler/integrationsource/integrationsource.go#L1
Please run goimports. diff --git a/pkg/reconciler/integrationsource/integrationsource.go b/pkg/reconciler/integrationsource/integrationsource.go index 9873568..d9dbda6 100644 --- a/pkg/reconciler/integrationsource/integrationsource.go +++ b/pkg/reconciler/integrationsource/integrationsource.go @@ -3,6 +3,7 @@ package integrationsource import ( "context" "fmt" + "go.uber.org/zap" corev1 "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/api/equality"
style / Golang / Auto-format and Check: pkg/reconciler/integrationsource/resources/containersource.go#L1
Please run goimports. diff --git a/pkg/reconciler/integrationsource/resources/containersource.go b/pkg/reconciler/integrationsource/resources/containersource.go index b891b2c..40a0434 100644 --- a/pkg/reconciler/integrationsource/resources/containersource.go +++ b/pkg/reconciler/integrationsource/resources/containersource.go @@ -2,14 +2,15 @@ package resources import ( "fmt" + "reflect" + "strconv" + "strings" + corev1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" sourcesv1 "knative.dev/eventing/pkg/apis/sources/v1" "knative.dev/eventing/pkg/apis/sources/v1alpha1" "knative.dev/pkg/kmeta" - "reflect" - "strconv" - "strings" ) func NewContainerSource(source *v1alpha1.IntegrationSource) *sourcesv1.ContainerSource {
style / Golang / Auto-format and Check
Process completed with exit code 1.
style / Golang / Lint: pkg/reconciler/integrationsource/resources/containersource.go#L8
could not import knative.dev/eventing/pkg/apis/sources/v1alpha1 (-: # knative.dev/eventing/pkg/apis/sources/v1alpha1
style / Golang / Lint: pkg/apis/sources/v1alpha1/integration_lifecycle.go#L58
conditions declared and not used
style / Golang / Lint: pkg/apis/sources/v1alpha1/integration_lifecycle.go#L59
observedGeneration declared and not used) (typecheck)
style / Golang / Lint: pkg/reconciler/integrationsource/controller.go#L35
could not import knative.dev/eventing/pkg/apis/sources/v1alpha1 (-: # knative.dev/eventing/pkg/apis/sources/v1alpha1
style / Golang / Lint: pkg/apis/sources/v1alpha1/integration_lifecycle.go#L58
conditions declared and not used
style / Golang / Lint: pkg/apis/sources/v1alpha1/integration_lifecycle.go#L59
observedGeneration declared and not used) (typecheck)
style / Golang / Lint: test/upgrade/prober/sut/broker.go#L97
ctx.T undefined (type Context has no field or method T) (typecheck)
style / Golang / Lint: test/upgrade/prober/sut/broker.go#L103
ctx.T undefined (type Context has no field or method T) (typecheck)
style / Golang / Lint: cmd/webhook/main.go#L21
could not import knative.dev/eventing/pkg/apis/sources/v1alpha1 (-: # knative.dev/eventing/pkg/apis/sources/v1alpha1
style / Golang / Lint: pkg/apis/sources/v1alpha1/integration_lifecycle.go#L58
conditions declared and not used
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / suggester / shell
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / suggester / yaml
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum