WIP: Integration sink and source: all together #6828
knative-style.yaml
on: pull_request
style
/
changes
2s
style
/
...
/
Auto-format and Check
16s
style
/
...
/
Lint
3m 31s
style
/
...
/
Do Not Submit
8s
style
/
...
/
shell
7s
style
/
...
/
yaml
17s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
29 errors and 6 warnings
style / suggester / yaml
Process completed with exit code 1.
|
style / Golang / Auto-format and Check:
cmd/controller/main.go#L1
Please run goimports.
diff --git a/cmd/controller/main.go b/cmd/controller/main.go
index bfca7ca..03dd21d 100644
--- a/cmd/controller/main.go
+++ b/cmd/controller/main.go
@@ -21,13 +21,14 @@ import (
// _ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
"errors"
- integrationSink "knative.dev/eventing/pkg/reconciler/integration/sink"
- integrationSource "knative.dev/eventing/pkg/reconciler/integration/source"
"log"
"net/http"
"os"
"time"
+ integrationSink "knative.dev/eventing/pkg/reconciler/integration/sink"
+ integrationSource "knative.dev/eventing/pkg/reconciler/integration/source"
+
"knative.dev/pkg/injection/sharedmain"
filteredFactory "knative.dev/pkg/client/injection/kube/informers/factory/filtered"
|
style / Golang / Auto-format and Check:
cmd/webhook/main.go#L1
Please run goimports.
diff --git a/cmd/webhook/main.go b/cmd/webhook/main.go
index fddd03f..76dc703 100644
--- a/cmd/webhook/main.go
+++ b/cmd/webhook/main.go
@@ -18,9 +18,10 @@ package main
import (
"context"
- sourcesv1alpha1 "knative.dev/eventing/pkg/apis/sources/v1alpha1"
"os"
+ sourcesv1alpha1 "knative.dev/eventing/pkg/apis/sources/v1alpha1"
+
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/kubernetes/scheme"
|
style / Golang / Auto-format and Check:
pkg/apis/sinks/v1alpha1/integration_sink_validation.go#L1
Please run goimports.
diff --git a/pkg/apis/sinks/v1alpha1/integration_sink_validation.go b/pkg/apis/sinks/v1alpha1/integration_sink_validation.go
index bb1ed9c..0d82564 100644
--- a/pkg/apis/sinks/v1alpha1/integration_sink_validation.go
+++ b/pkg/apis/sinks/v1alpha1/integration_sink_validation.go
@@ -18,6 +18,7 @@ package v1alpha1
import (
"context"
+
"knative.dev/pkg/apis"
)
|
style / Golang / Auto-format and Check:
pkg/apis/sources/v1alpha1/integration_conversion.go#L1
Please run goimports.
diff --git a/pkg/apis/sources/v1alpha1/integration_conversion.go b/pkg/apis/sources/v1alpha1/integration_conversion.go
index 6b0235d..32bfc7c 100644
--- a/pkg/apis/sources/v1alpha1/integration_conversion.go
+++ b/pkg/apis/sources/v1alpha1/integration_conversion.go
@@ -19,6 +19,7 @@ package v1alpha1
import (
"context"
"fmt"
+
"knative.dev/pkg/apis"
)
|
style / Golang / Auto-format and Check:
pkg/apis/sources/v1alpha1/integration_conversion_test.go#L1
Please run goimports.
diff --git a/pkg/apis/sources/v1alpha1/integration_conversion_test.go b/pkg/apis/sources/v1alpha1/integration_conversion_test.go
index 93d712e..2272ecc 100644
--- a/pkg/apis/sources/v1alpha1/integration_conversion_test.go
+++ b/pkg/apis/sources/v1alpha1/integration_conversion_test.go
@@ -19,8 +19,9 @@ package v1alpha1
import (
"context"
"errors"
- "knative.dev/pkg/apis"
"testing"
+
+ "knative.dev/pkg/apis"
)
// implement apis.Convertible
|
style / Golang / Auto-format and Check:
pkg/apis/sources/v1alpha1/integration_defaults_test.go#L1
Please run goimports.
diff --git a/pkg/apis/sources/v1alpha1/integration_defaults_test.go b/pkg/apis/sources/v1alpha1/integration_defaults_test.go
index 3497c91..ed58649 100644
--- a/pkg/apis/sources/v1alpha1/integration_defaults_test.go
+++ b/pkg/apis/sources/v1alpha1/integration_defaults_test.go
@@ -18,8 +18,9 @@ package v1alpha1
import (
"context"
- "github.com/google/go-cmp/cmp"
"testing"
+
+ "github.com/google/go-cmp/cmp"
)
func TestSetDefaults(t *testing.T) {
|
style / Golang / Auto-format and Check:
pkg/apis/sources/v1alpha1/integration_lifecycle_test.go#L1
Please run goimports.
diff --git a/pkg/apis/sources/v1alpha1/integration_lifecycle_test.go b/pkg/apis/sources/v1alpha1/integration_lifecycle_test.go
index 1b88bf1..26b2a00 100644
--- a/pkg/apis/sources/v1alpha1/integration_lifecycle_test.go
+++ b/pkg/apis/sources/v1alpha1/integration_lifecycle_test.go
@@ -17,13 +17,14 @@ limitations under the License.
package v1alpha1
import (
+ "testing"
+
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
corev1 "k8s.io/api/core/v1"
v1 "knative.dev/eventing/pkg/apis/sources/v1"
"knative.dev/pkg/apis"
duckv1 "knative.dev/pkg/apis/duck/v1"
- "testing"
)
var (
|
style / Golang / Auto-format and Check:
pkg/apis/sources/v1alpha1/integration_validation.go#L1
Please run goimports.
diff --git a/pkg/apis/sources/v1alpha1/integration_validation.go b/pkg/apis/sources/v1alpha1/integration_validation.go
index 5d2a28e..4df223e 100644
--- a/pkg/apis/sources/v1alpha1/integration_validation.go
+++ b/pkg/apis/sources/v1alpha1/integration_validation.go
@@ -18,6 +18,7 @@ package v1alpha1
import (
"context"
+
"knative.dev/pkg/apis"
)
|
style / Golang / Auto-format and Check:
pkg/reconciler/integration/helper.go#L1
Please run goimports.
diff --git a/pkg/reconciler/integration/helper.go b/pkg/reconciler/integration/helper.go
index 9b86eed..b160591 100644
--- a/pkg/reconciler/integration/helper.go
+++ b/pkg/reconciler/integration/helper.go
@@ -2,10 +2,11 @@ package integration
import (
"fmt"
- corev1 "k8s.io/api/core/v1"
"reflect"
"strconv"
"strings"
+
+ corev1 "k8s.io/api/core/v1"
)
const prefix = "CAMEL_KAMELET_"
|
style / Golang / Auto-format and Check:
pkg/reconciler/integration/sink/controller.go#L1
Please run goimports.
diff --git a/pkg/reconciler/integration/sink/controller.go b/pkg/reconciler/integration/sink/controller.go
index 351feed..2348e84 100644
--- a/pkg/reconciler/integration/sink/controller.go
+++ b/pkg/reconciler/integration/sink/controller.go
@@ -2,6 +2,7 @@ package sink
import (
"context"
+
"k8s.io/client-go/tools/cache"
"knative.dev/eventing/pkg/apis/feature"
"knative.dev/eventing/pkg/client/injection/informers/eventing/v1alpha1/eventpolicy"
|
style / Golang / Boilerplate Check (go):
pkg/reconciler/integration/helper.go#L1
[Go headers] reported by reviewdog 🐶
missing boilerplate:
Raw Output:
pkg/reconciler/integration/helper.go:1: missing boilerplate:
/*
Copyright 2024 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
|
style / Golang / Boilerplate Check (go):
pkg/reconciler/integration/sink/controller.go#L1
[Go headers] reported by reviewdog 🐶
missing boilerplate:
Raw Output:
pkg/reconciler/integration/sink/controller.go:1: missing boilerplate:
/*
Copyright 2024 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
|
style / Golang / Boilerplate Check (go):
pkg/reconciler/integration/sink/integrationsink.go#L1
[Go headers] reported by reviewdog 🐶
missing boilerplate:
Raw Output:
pkg/reconciler/integration/sink/integrationsink.go:1: missing boilerplate:
/*
Copyright 2024 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
|
style / Golang / Boilerplate Check (go):
pkg/reconciler/integration/sink/resources/container_image.go#L1
[Go headers] reported by reviewdog 🐶
missing boilerplate:
Raw Output:
pkg/reconciler/integration/sink/resources/container_image.go:1: missing boilerplate:
/*
Copyright 2024 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
|
style / Golang / Boilerplate Check (go):
pkg/reconciler/integration/sink/resources/labels.go#L8
[Go headers] reported by reviewdog 🐶
found mismatched boilerplate lines:
Raw Output:
pkg/reconciler/integration/sink/resources/labels.go:8: found mismatched boilerplate lines:
{[]string}[0]:
-: "\thttp://www.apache.org/licenses/LICENSE-2.0"
+: " http://www.apache.org/licenses/LICENSE-2.0"
|
style / Golang / Boilerplate Check (go):
pkg/reconciler/integration/source/resources/containersource.go#L1
[Go headers] reported by reviewdog 🐶
missing boilerplate:
Raw Output:
pkg/reconciler/integration/source/resources/containersource.go:1: missing boilerplate:
/*
Copyright 2024 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
|
style / Golang / Boilerplate Check (go):
pkg/reconciler/integration/source/resources/labels.go#L8
[Go headers] reported by reviewdog 🐶
found mismatched boilerplate lines:
Raw Output:
pkg/reconciler/integration/source/resources/labels.go:8: found mismatched boilerplate lines:
{[]string}[0]:
-: "\thttp://www.apache.org/licenses/LICENSE-2.0"
+: " http://www.apache.org/licenses/LICENSE-2.0"
|
style / Golang / Boilerplate Check (go)
Process completed with exit code 1.
|
|
|
style / Golang / Lint:
pkg/apis/sources/v1alpha1/integration_types_test.go#L94
undefined: SecretReference
|
style / Golang / Lint:
pkg/apis/sources/v1alpha1/integration_validation_test.go#L48
cannot use &AWSS3{…} (value of type *AWSS3) as *"knative.dev/eventing/pkg/apis/common".AWSS3 value in struct literal
|
|
|
style / Golang / Lint:
pkg/apis/sources/v1alpha1/integration_validation_test.go#L56
undefined: SecretReference
|
style / Golang / Lint:
pkg/apis/sources/v1alpha1/integration_validation_test.go#L69
cannot use &AWSSQS{…} (value of type *AWSSQS) as *"knative.dev/eventing/pkg/apis/common".AWSSQS value in struct literal
|
|
|
style / suggester / shell
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
style / suggester / yaml
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|