Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readiness and liveness probes in pingsource-mt-adapter #8192

Open
airycanon opened this issue Sep 13, 2024 · 5 comments · May be fixed by #8308
Open

Add readiness and liveness probes in pingsource-mt-adapter #8192

airycanon opened this issue Sep 13, 2024 · 5 comments · May be fixed by #8308
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@airycanon
Copy link

Problem
The pingsource-mt-adapter currently lacks readiness and liveness probes.

Persona:
System Operator

Exit Criteria
Probes are implemented and correctly indicats the pingsource-mt-adapter is healthy.

@pierDipi
Copy link
Member

Would you be interested in contributing this feature?
If you’re interested, I’d be happy to provide any additional information or resources you might need to get started. We have documentation available (development doc), and I’m also here or on CNCF Slack to answer any questions you might have.

/triage accepted
/help

Copy link

knative-prow bot commented Sep 19, 2024

@pierDipi:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Would you be interested in contributing this feature?
If you’re interested, I’d be happy to provide any additional information or resources you might need to get started. We have documentation available (development doc), and I’m also here or on CNCF Slack to answer any questions you might have.

/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added triage/accepted Issues which should be fixed (post-triage) help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 19, 2024
@pranjalg1331
Copy link

Hi I would like to help contribute in this issue.

@airycanon
Copy link
Author

airycanon commented Oct 12, 2024

@pierDipi Hey, I've got a couple questions hoping you could help me with:

  1. I noticed the controller already has some health checks code in there:
    https://github.com/knative/eventing/blob/main/cmd/controller/main.go#L57-L67.
    Would it be possible to extract that code into https://github.com/knative/pkg for reusing?
  2. Are there any other components that also need health checks? If so, would it be alright if I implement those as well using the shared code above?

@pierDipi
Copy link
Member

pierDipi commented Nov 4, 2024

@airycanon knative/pkg already runs an health probe server [1], if it's not disabled, maybe we could leverage it?

[1] https://github.com/knative/pkg/blob/25f6002b00f3562c48e4fa6f18882829c61cc73f/injection/sharedmain/main.go#L320-L325

@airycanon airycanon linked a pull request Nov 6, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants