Updated to sdk-go 2.0.0-RC4 #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Guardiani <[email protected]>
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
@slinkydeveloper Yo! Do you want to follow up w/ this version bump for I wonder if we merge this, if than contrib is in a bad state again 😝 |
|
@matzew i'll do that now, but as far as i understood, with go mod it's not a problem anymore if we don't have these two aligned. Also this release bump doesn't have any breaking change |
|
/lgtm
WAT CAN POSSIBLY GO WRONG???
:troll face:,
On Thu 14. May 2020 at 08:27, Francesco Guardiani ***@***.***> wrote:
@matzew <https://github.com/matzew> i'll do that now, but as far as i
understood, with go mod it's not a problem anymore if we don't have these
two aligned. Also this release bump doesn't have any breaking change
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3136 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGPTVEIIGM3RTVESSC4W3RROFOLANCNFSM4M7Z7DSA>
.
--
Sent from Gmail Mobile
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Francesco Guardiani [email protected]
Release Note