Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch EventType reconciler to v1beta1 version #3200

Merged
merged 8 commits into from
May 26, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented May 23, 2020

Fixes #

Proposed Changes

  • Switches over the EventType reconciler to operate on the v1beta1 EventType resource
    • Still uses v1alpha1 Broker

Release Note


- Update EventType reconciler v1alpha1 -> v1beta1

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 23, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 23, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 23, 2020
@whaught whaught changed the title [WIP] Switch EventType reconciler to v1beta1 version Switch EventType reconciler to v1beta1 version May 23, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2020
@whaught
Copy link
Contributor Author

whaught commented May 23, 2020

/hold

The 0.15 release cut is soon, hold until after that is made

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2020
@whaught
Copy link
Contributor Author

whaught commented May 23, 2020

/assign @vaikas @n3wscott

"knative.dev/pkg/configmap"
"knative.dev/pkg/controller"
"knative.dev/pkg/tracker"

"knative.dev/eventing/pkg/apis/eventing/v1alpha1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for here,

v1alpha1.SchemeGroupVersion.WithKind("Broker"),

can we use beta1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the moment this is still using v1alpha1.Broker everywhere - this PR is intended only to update the EventType resource. Someone more familiar would have to explain if we ought to be reconciling v1beta1.Broker?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we're still reconciling with v1alpha1 for Brokers since v1beta1 is lossy. We'll drop v1alpha1 support and let's do the move to v1beta1 as part of that.

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/broker_conversion.go 88.9% 81.5% -7.4
pkg/apis/eventing/v1beta1/eventtype_lifecycle.go Do not exist 71.4%
pkg/apis/eventing/v1beta1/eventtype_types.go 50.0% 66.7% 16.7

@vaikas
Copy link
Contributor

vaikas commented May 26, 2020

/lgtm
/approve

Thanks!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@whaught
Copy link
Contributor Author

whaught commented May 26, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@knative-prow-robot knative-prow-robot merged commit b43f161 into knative:master May 26, 2020
@whaught whaught deleted the switch-version branch May 28, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants