Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct namespace for namespace reconciliation events #3258

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

devguyio
Copy link
Contributor

@devguyio devguyio commented Jun 3, 2020

Namespace events created during reconciliation end up in default namespace. This gives a bad and unexpected UX for Eventing users since in our case, the user is interacting with Triggers and Brokers that are in a specific namespace and expects Events being there.

Fixes #3084

Proposed Changes

  • Enforcing namespace for namespace reconciliation events with regards to broker creation.

Release Note

When default broker is created via namespace reconciler, the Kubernetes events will be created in the correct namespace instead of some of them getting created in default namespace.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 3, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2020
@devguyio
Copy link
Contributor Author

devguyio commented Jun 3, 2020

/assign @grantr

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/mtnamespace/namespace.go 82.4% 83.3% 1.0

@lberk
Copy link
Member

lberk commented Jun 3, 2020

/assign

Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 3, 2020
@devguyio
Copy link
Contributor Author

devguyio commented Jun 3, 2020

/honk

@devguyio
Copy link
Contributor Author

devguyio commented Jun 3, 2020

/woof

@knative-prow-robot
Copy link
Contributor

@Abd4llA: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@devguyio
Copy link
Contributor Author

devguyio commented Jun 3, 2020

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2020
@devguyio
Copy link
Contributor Author

devguyio commented Jun 3, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2020
@pierDipi
Copy link
Member

pierDipi commented Jun 3, 2020

/uncc slinkydeveloper
/uncc vaikas
/lgtm
/approve

@matzew
Copy link
Member

matzew commented Jun 3, 2020

/honk

/honk

@matzew
Copy link
Member

matzew commented Jun 3, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abd4llA, matzew, n3wscott, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chizhg
Copy link
Member

chizhg commented Jun 3, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit cdc8e03 into knative:master Jun 3, 2020
@devguyio devguyio deleted the 3084-events-namespace branch June 3, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

knative-eventing-namespace-controller creates events in the "default" namespace
10 participants