Add sources metadata conformance test #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/L
mattmoor
reviewed
Jun 22, 2020
test/e2e_flags.go
Outdated
| @@ -35,6 +35,9 @@ const ( | |||
| BrokerUsage = "Which brokerclass to test, requires the proper Broker " + | |||
| "implementation to have been installed, and only one value. brokerclass " + | |||
| "must be (for now) 'MTChannelBasedBroker'." | |||
| SourceUsage = "The names of the source type metas, separated by comma. " + | |||
There was a problem hiding this comment.
Format Go code:
Suggested change
| SourceUsage = "The names of the source type metas, separated by comma. " + | |
| SourceUsage = "The names of the source type metas, separated by comma. " + |
matzew
reviewed
Jun 22, 2020
| ) | ||
|
|
||
| var sourceLabels = map[string]string{ | ||
| "duck.knative.dev/source": "true", |
There was a problem hiding this comment.
until we have knative/pkg#1424 available, let's go w/ this
|
/assign |
antoineco
suggested changes
Jun 22, 2020
test/flags/sources.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // Check if the Source name is valid. |
There was a problem hiding this comment.
Suggested change
| // Check if the Source name is valid. | |
| // Check if the Source kind is valid. |
aliok
reviewed
Jun 22, 2020
test/flags/sources.go
Outdated
Comment on lines
36
to
53
| for _, source := range strings.Split(value, ",") { | ||
| source := strings.TrimSpace(source) | ||
| split := strings.Split(source, ":") | ||
| if len(split) != 2 { | ||
| log.Fatalf("The given Source name %q is invalid, it needs to be in the form \"apiVersion:Kind\".", source) | ||
| } | ||
| tm := metav1.TypeMeta{ | ||
| APIVersion: split[0], | ||
| Kind: split[1], | ||
| } | ||
| if !isValidSource(tm.Kind) { | ||
| log.Fatalf("The given Source name %q is invalid, tests cannot be run.\n", source) | ||
| } | ||
|
|
||
| *sources = append(*sources, tm) | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This can be extracted into a separate function and can be reused in sources.go and channels.go. ...if you feel for it
aliok
reviewed
Jun 22, 2020
There was a problem hiding this comment.
Can you also update the test script so that it runs the conformance tests against the sources defined in knative/eventing?
I see following line in the logs:
Running tests with 'go test -v -race -count=1 -tags=e2e -timeout=20m -parallel=12 ./test/e2e ./test/conformance -brokerclass=MTChannelBasedBroker -channels=messaging.knative.dev/v1beta1:Channel,messaging.knative.dev/v1beta1:InMemoryChannel '
no sources mentioned there.
aliok
reviewed
Jun 22, 2020
test/flags/channels.go
Outdated
| @@ -27,28 +26,15 @@ import ( | |||
| // Channels holds the Channels we want to run test against. | |||
| type Channels []metav1.TypeMeta | |||
|
|
|||
| var objs []metav1.TypeMeta | |||
aliok
reviewed
Jun 22, 2020
| @@ -35,6 +35,6 @@ initialize $@ --skip-istio-addon | |||
| install_mt_broker || fail_test "Could not install MT Channel Based Broker" | |||
|
|
|||
| echo "Running tests with Multi Tenant Channel Based Broker" | |||
| go_test_e2e -timeout=20m -parallel=12 ./test/e2e ./test/conformance -brokerclass=MTChannelBasedBroker -channels=messaging.knative.dev/v1beta1:Channel,messaging.knative.dev/v1beta1:InMemoryChannel || fail_test | |||
| go_test_e2e -timeout=20m -parallel=12 ./test/e2e ./test/conformance -brokerclass=MTChannelBasedBroker -channels=messaging.knative.dev/v1beta1:Channel,messaging.knative.dev/v1beta1:InMemoryChannel -sources=sources.knative.dev/v1alpha2:ApiServerSource,sources.knative.dev/v1alpha2:ContainerSource,sources.knative.dev/v1alpha2:PingSource || fail_test | |||
aliok
approved these changes
Jun 22, 2020
|
/assign |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Abd4llA, aliok, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3116
Proposed Changes
-sourcese2e testing flagRelease Note