Accept both B3 and TraceContext style tracing #3388
Conversation
…ontext style. Egressing only TraceContext style is done for backwards compatibility with the existing system, which sends TraceContext style. We could output both styles, but it was determined that the additional overhead of ~100 bytes on every outgoing message was not worth it.
knative-prow-robot
added
size/L
Harwayne
force-pushed
the
tracecontext-egress
branch
from
de158b1
to
b5988cf
Compare
|
/assign @slinkydeveloper |
| @@ -188,7 +189,9 @@ func vegetaAttackerTransport() *http.Transport { | |||
| func newCloudEventsClient(sinkUrl string) (cloudevents.Client, error) { | |||
| t, err := cloudevents.NewHTTP( | |||
| cloudevents.WithTarget(sinkUrl), | |||
| ) | |||
| cloudevents.WithRoundTripper(&ochttp.Transport{ | |||
There was a problem hiding this comment.
I don't think we need tracing in performance images, it's not even configured
| t, err := cloudevents.NewHTTP(cloudevents.WithPort(8080)) | ||
| t, err := cloudevents.NewHTTP( | ||
| cloudevents.WithPort(8080), | ||
| cloudevents.WithRoundTripper(&ochttp.Transport{ |
There was a problem hiding this comment.
This image uses only the receiver, so you don't need WithRoundTripper, because it's used only for the underlying HTTP client, for the server side you need to use WithMiddleware (you could easily reuse kncloudevents.CreateHandler for this)
| t, err := cloudevents.NewHTTP(cloudevents.WithPort(8080)) | ||
| t, err := cloudevents.NewHTTP( | ||
| cloudevents.WithPort(8080), | ||
| cloudevents.WithRoundTripper(&ochttp.Transport{ |
There was a problem hiding this comment.
Same as comment above
knative-prow-robot
added
size/M
|
The following is the coverage report on the affected files.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Harwayne, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* hack/update-deps.sh * Accept both TraceContext and B3 style trace formats. Send only TraceContext style. Egressing only TraceContext style is done for backwards compatibility with the existing system, which sends TraceContext style. We could output both styles, but it was determined that the additional overhead of ~100 bytes on every outgoing message was not worth it. * Update CE clients. * hack/update-deps.sh * PR comments. * Undo changes to http_load_generator.go.
Proposed Changes
Release Note