Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding broker cleaner script to post-0.16.0 install #3439

Merged
merged 7 commits into from
Jul 1, 2020

Conversation

n3wscott
Copy link
Contributor

Fixes #3225

Proposed Changes

  • Delete stray Deployments in every namespace owned by a Broker with ChannelBroker class.
  • Delete stray RoleBindings and ServiceAccounts from namespaces that had a Broker with ChannelBroker class.
  • Delete scaled to zero deployments for mt-broker inside of knative-eventing namespace (we renamed the deployments)

Release Note

Optionally apply <release path>/post-install-to-v0.16.0.yaml to clean up left over Broker resources in all namespaces.

Docs

@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 30, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jun 30, 2020
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

cmd/broker-juggler/README.md Outdated Show resolved Hide resolved
cmd/broker-juggler/README.md Outdated Show resolved Hide resolved
cmd/broker-juggler/README.md Outdated Show resolved Hide resolved
cmd/broker-juggler/README.md Outdated Show resolved Hide resolved
cmd/broker-juggler/README.md Outdated Show resolved Hide resolved
cmd/broker-juggler/README.md Outdated Show resolved Hide resolved
cmd/broker-juggler/README.md Outdated Show resolved Hide resolved
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

cmd/broker-juggler/main.go Outdated Show resolved Hide resolved
cmd/broker-juggler/main.go Outdated Show resolved Hide resolved
cmd/broker-juggler/main.go Outdated Show resolved Hide resolved
@matzew
Copy link
Member

matzew commented Jun 30, 2020

/home/prow/go/src/knative.dev/eventing is out of date. Please run hack/update-codegen.sh

@matzew
Copy link
Member

matzew commented Jun 30, 2020

Perhaps it is just me, but I don't understand why this is in cmd/broker-juggler

I'd think it is more reasonable to be in something like cmd/upgrade, like we had before:
https://github.com/knative/eventing/tree/v0.15.0/cmd/upgrade

@n3wscott
Copy link
Contributor Author

/hold

New updates are being validated with my script.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2020
@n3wscott
Copy link
Contributor Author

n3wscott commented Jul 1, 2020

/unhold

Looks good

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020
@vaikas
Copy link
Contributor

vaikas commented Jul 1, 2020

/lgtm
/approve

Thanks! neat about dumping all the cleaned resources in yaml log 👍

@vaikas
Copy link
Contributor

vaikas commented Jul 1, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@knative-prow-robot knative-prow-robot merged commit c68d174 into knative:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a post-install step that deletes the Deprecated deployments.
5 participants