Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SubscriberSpec implement apis.Convertible #3473

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Make SubscriberSpec implement apis.Convertible #3473

merged 1 commit into from
Jul 6, 2020

Conversation

aliok
Copy link
Member

@aliok aliok commented Jul 3, 2020 •
edited
Loading

Part of #3474

Same story with #3471 , but for SubscriberSpec

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 3, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2020
@aliok aliok force-pushed the duck_conv_03_SubscriberSpec branch 4 times, most recently from b62c60e to 3d3a7c3 Compare July 3, 2020 10:26
@aliok aliok mentioned this pull request Jul 3, 2020
Merged
@aliok
Copy link
Member Author

aliok commented Jul 3, 2020

/retest

2 similar comments
@aliok
Copy link
Member Author

aliok commented Jul 3, 2020

/retest

@aliok
Copy link
Member Author

aliok commented Jul 3, 2020

/retest

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestBrokerChannelFlowTriggerV1BrokerV1
test/e2e.TestSingleStructuredEventForChannelV1Beta1
test/e2e.TestBrokerChannelFlowTriggerV1BrokerV1/Channel-messaging.knative.dev/v1
test/e2e.TestSingleStructuredEventForChannelV1Beta1/Channel-messaging.knative.dev/v1

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2020
@aliok aliok force-pushed the duck_conv_03_SubscriberSpec branch from 3d3a7c3 to 375c698 Compare July 6, 2020 06:32
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2020
@aliok aliok changed the title [WIP] Make SubscriberSpec implement apis.Convertible Make SubscriberSpec implement apis.Convertible Jul 6, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2020
@nlopezgi
Copy link
Contributor

nlopezgi commented Jul 6, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@aliok aliok force-pushed the duck_conv_03_SubscriberSpec branch from 375c698 to d7d1dc5 Compare July 6, 2020 18:40
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@aliok
Copy link
Member Author

aliok commented Jul 6, 2020

@nlopezgi rebased

@aliok aliok force-pushed the duck_conv_03_SubscriberSpec branch from d7d1dc5 to 3ad9d01 Compare July 6, 2020 18:50
@vaikas
Copy link
Contributor

vaikas commented Jul 6, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/duck/v1alpha1/subscribable_types_conversion.go 98.2% 98.4% 0.2
pkg/apis/duck/v1beta1/subscribable_types_conversion.go 96.5% 96.7% 0.2

@nlopezgi
Copy link
Contributor

nlopezgi commented Jul 6, 2020

/lgtm

@knative-prow-robot knative-prow-robot merged commit 4912b7e into knative:master Jul 6, 2020
@aliok aliok deleted the duck_conv_03_SubscriberSpec branch July 6, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew Awaiting requested review from matzew

@yolocs yolocs Awaiting requested review from yolocs

Assignees

@nlopezgi nlopezgi

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aliok @knative-test-reporter-robot @nlopezgi @vaikas @knative-prow-robot @knative-metrics-robot @googlebot