Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix log message #4030

Merged
merged 1 commit into from
Sep 10, 2020
Merged

fix log message #4030

merged 1 commit into from
Sep 10, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Sep 10, 2020

Fix the incorrect message, would print %s/%s instead of t.ns/t.name

Proposed Changes

  • fix the log message

Release Note

- 🐛 Fix bug
When not reconciling triggers not owned by my brokerclass, would print incorrect msg, logic was correct however, just wrong log message.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 10, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020
@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@knative-prow-robot knative-prow-robot merged commit 9d689ca into knative:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantr grantr Awaiting requested review from grantr

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vaikas @knative-prow-robot @lionelvillard @googlebot