do not hardcode the URI, use ref instead

[vaikas]

Proposed Changes

• Follow up to discussion in Drop the hardcoded cluster.local #4277

Release Note

- 🧽 Update or clean up current behavior
Point to Broker ref instead of using a hard coded path. Also makes things little easier to reuse against other brokers.

Docs

[codecov]

Codecov Report

Merging #4278 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4278   +/-   ##
=======================================
  Coverage   80.25%   80.25%           
=======================================
  Files         287      287           
  Lines        7887     7887           
=======================================
  Hits         6330     6330           
  Misses       1174     1174           
  Partials      383      383           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1d8d7...f9ae776. Read the comment docs.

[matzew]

I like using rhe ref!

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [matzew,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vaikas]

=== CONT  TestBrokerChannelFlowTriggerV1BrokerV1Beta1/InMemoryChannel-messaging.knative.dev/v1
    operation.go:121: Waiting for 1 endpoints in service e2e-brokerchannel-logger-pod1
    creation.go:409: Creating v1 trigger e2e-brokerchannel-trigger2
    creation.go:80: Creating channel &TypeMeta{Kind:InMemoryChannel,APIVersion:messaging.knative.dev/v1,}-e2e-brokerchannel-channel
    broker_channel_flow_helper.go:160: Failed to get the url for the channel "e2e-brokerchannel-channel": addressable does not have an Address: &{TypeMeta:{Kind:InMemoryChannel APIVersion:messaging.knative.dev/v1} ObjectMeta:{Name:e2e-brokerchannel-channel GenerateName: Namespace:test-broker-channel-flow-trigger-v1-broker-v1-beta1-in-memvfkvz SelfLink:/apis/messaging.knative.dev/v1/namespaces/test-broker-channel-flow-trigger-v1-broker-v1-beta1-in-memvfkvz/inmemorychannels/e2e-brokerchannel-channel UID:49bf5386-b075-4868-9f8e-109eb65d8296 ResourceVersion:33564 Generation:1 CreationTimestamp:2020-10-12 08:10:08 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[messaging.knative.dev/creator:[email protected] messaging.knative.dev/lastModifier:[email protected] messaging.knative.dev/subscribable:v1] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]} Status:{Address:<nil>}}
        knative.dev/eventing/test/lib.(*Client).GetAddressableURI
        	/home/prow/go/src/knative.dev/eventing/test/lib/operation.go:57
        knative.dev/eventing/test/e2e/helpers.BrokerChannelFlowWithTransformation.func1
        	/home/prow/go/src/knative.dev/eventing/test/e2e/helpers/broker_channel_flow_helper.go:158
        knative.dev/eventing/test/lib.(*ComponentsTestRunner).RunTests.func1
        	/home/prow/go/src/knative.dev/eventing/test/lib/test_runner.go:75
        testing.tRunner
        	/root/.gvm/gos/go1.14.6/src/testing/testing.go:1039
        runtime.goexit
        	/root/.gvm/gos/go1.14.6/src/runtime/asm_amd64.s:1373

And then.

    tracker.go:129: Cleaning resource: "e2e-brokerchannel-channel"
        {
          "apiVersion": "messaging.knative.dev/v1",
          "kind": "InMemoryChannel",
          "metadata": {
            "annotations": {
              "messaging.knative.dev/creator": "[email protected]",
              "messaging.knative.dev/lastModifier": "[email protected]",
              "messaging.knative.dev/subscribable": "v1"
            },
            "creationTimestamp": "2020-10-12T08:10:08Z",
            "generation": 1,
            "name": "e2e-brokerchannel-channel",
            "namespace": "test-broker-channel-flow-trigger-v1-broker-v1-beta1-in-memvfkvz",
            "resourceVersion": "33564",
            "selfLink": "/apis/messaging.knative.dev/v1/namespaces/test-broker-channel-flow-trigger-v1-broker-v1-beta1-in-memvfkvz/inmemorychannels/e2e-brokerchannel-channel",
            "uid": "49bf5386-b075-4868-9f8e-109eb65d8296"
          },
          "spec": {},
          "status": {
            "conditions": [
              {
                "lastTransitionTime": "2020-10-12T08:10:08Z",
                "status": "Unknown",
                "type": "Addressable"
              },
              {
                "lastTransitionTime": "2020-10-12T08:10:08Z",
                "status": "Unknown",
                "type": "ChannelServiceReady"
              },
              {
                "lastTransitionTime": "2020-10-12T08:10:08Z",
                "status": "Unknown",
                "type": "DispatcherReady"
              },
              {
                "lastTransitionTime": "2020-10-12T08:10:08Z",
                "status": "Unknown",
                "type": "EndpointsReady"
              },
              {
                "lastTransitionTime": "2020-10-12T08:10:08Z",
                "message": "unsuccessfully observed a new generation",
                "reason": "NewObservedGenFailure",
                "status": "Unknown",
                "type": "Ready"
              },
              {
                "lastTransitionTime": "2020-10-12T08:10:08Z",
                "status": "Unknown",
                "type": "ServiceReady"
              }
            ],
            "observedGeneration": 1
          }
        }

[vaikas]

/test pull-knative-eventing-integration-tests