Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of flakiness recently, which hopefully this can address.
The idea of this change being that
prober.ReceiverDone()
will poll for the receiver to have received all the sender's events, whereas before we were just doingprober.AssertReceivedAll
. The latter works fine as long as the time betweenSenderDone
andReceiverDone
is close to 0, which it seems to be on my machine. However if there's enough of a delay (as I think might be the case in a GitHub Action kind env), the assert will kick in before the receiver and it immediately will fail.https://github.com/knative/eventing/runs/2817796102?check_suite_focus=true#step:12:4213
https://github.com/knative/eventing/runs/2818732715?check_suite_focus=true#step:12:5736
https://github.com/knative/eventing/runs/2820524189?check_suite_focus=true#step:12:4820
https://github.com/knative/eventing/runs/2821565820?check_suite_focus=true#step:12:4827
https://github.com/knative/eventing/runs/2821629829?check_suite_focus=true#step:12:5384
https://github.com/knative/eventing/runs/2822529840?check_suite_focus=true#step:12:4251