Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go 1.18 #6470

Merged
merged 1 commit into from
Aug 4, 2022
Merged

use go 1.18 #6470

merged 1 commit into from
Aug 4, 2022

Conversation

lionelvillard
Copy link
Member

@lionelvillard lionelvillard commented Aug 3, 2022

knative/pkg uses 1.18 features.

@knative-prow
Copy link

knative-prow bot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #6470 (c298c66) into main (15dd7ca) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6470      +/-   ##
==========================================
+ Coverage   82.15%   82.18%   +0.02%     
==========================================
  Files         235      235              
  Lines       11694    11712      +18     
==========================================
+ Hits         9607     9625      +18     
  Misses       1620     1620              
  Partials      467      467              
Impacted Files Coverage Δ
pkg/broker/ingress/ingress_handler.go 77.33% <0.00%> (ø)
pkg/adapter/apiserver/events/events.go 94.11% <0.00%> (+0.30%) ⬆️
pkg/kncloudevents/message_receiver.go 93.50% <0.00%> (+1.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lionelvillard
Copy link
Member Author

/test reconciler-tests_eventing_main

@matzew
Copy link
Member

matzew commented Aug 4, 2022

PKG PR is here: knative/pkg#2548

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2022
@lionelvillard lionelvillard changed the title use go 1.18 and update deps use go 1.18 Aug 4, 2022
@lionelvillard
Copy link
Member Author

/assign @matzew @pierDipi

@aslom
Copy link
Member

aslom commented Aug 4, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2022
@knative-prow knative-prow bot merged commit f7e8eef into knative:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants