Remove deprecated httpclient msgsender

pkg/inmemorychannel/message_dispatcher_benchmark_test.go

@@ -76,12 +76,6 @@ func BenchmarkDispatcher_dispatch_ok_through_2_channels(b *testing.B) {
 		},
 	}
 
-	// Let's mock this stuff!
-	httpSender, err := kncloudevents.NewHTTPMessageSenderWithTarget(channelA.URL.String())
-	if err != nil {
-		b.Fatal(err)
-	}
-
 	multiChannelFanoutHandler, err := multichannelfanout.NewMessageHandlerWithConfig(context.TODO(), logger, channel.NewMessageDispatcher(logger), config, reporter)
 	if err != nil {
 		b.Fatal(err)
@@ -96,7 +90,6 @@ func BenchmarkDispatcher_dispatch_ok_through_2_channels(b *testing.B) {
 
 	dispatcher := NewMessageDispatcher(dispatcherArgs)
 	requestHandler := kncloudevents.CreateHandler(dispatcher.handler)
-	httpSender.Client = mockedHTTPClient(clientMock(channelA.URL.Host, transformations.URL.Host, channelB.URL.Host, receiver.URL.Host, requestHandler))
 
 	// Start the bench
 	b.ResetTimer()

pkg/inmemorychannel/message_dispatcher_test.go

@@ -258,29 +258,9 @@ func TestDispatcher_dispatch(t *testing.T) {
 	}()
 	dispatcher.WaitReady()
 
-	// Ok now everything should be ready to send the event
-	httpsender, err := kncloudevents.NewHTTPMessageSenderWithTarget(channelAProxy.URL)
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	req, err := httpsender.NewCloudEventRequest(context.Background())
-	if err != nil {
-		t.Fatal(err)
-	}
-
 	event := test.FullEvent()
 	_ = protocolhttp.WriteRequest(context.Background(), binding.ToMessage(&event), req)
 
-	res, err := httpsender.Send(req)
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	if res.StatusCode != http.StatusAccepted {
-		t.Fatal("Expected 202, Have", res.StatusCode)
-	}
-
 	transformationsFailureWg.Wait()
 	deadLetterWg.Wait()
 	err = <-transformationsCh

pkg/kncloudevents/http_client_new.go

@@ -132,7 +132,6 @@ func DeleteAddressableHandler(addressable duckv1.Addressable) {
 // ConfigureConnectionArgs configures the new connection args.
 // Use sparingly, because it might lead to creating a lot of clients, none of them sharing their connection pool!
 func ConfigureConnectionArgs(ca *ConnectionArgs) {
-	configureConnectionArgsOldClient(ca) //also configure the connection args of the old client
 
 	clients.clientsMu.Lock()
 	defer clients.clientsMu.Unlock()