-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable PingSource TLS E2E test #7082
Re-enable PingSource TLS E2E test #7082
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7082 +/- ##
==========================================
+ Coverage 78.29% 78.31% +0.02%
==========================================
Files 250 250
Lines 13290 13320 +30
==========================================
+ Hits 10405 10432 +27
- Misses 2353 2357 +4
+ Partials 532 531 -1
☔ View full report in Codecov by Sentry. |
1/1 worked, retesting |
2/2 worked, retesting |
|
Signed-off-by: Pierangelo Di Pilato <[email protected]>
f3eee7c
to
d815e1d
Compare
Signed-off-by: Pierangelo Di Pilato <[email protected]>
d815e1d
to
936270d
Compare
|
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
287a337
to
8024abe
Compare
Signed-off-by: Pierangelo Di Pilato <[email protected]>
8024abe
to
6486546
Compare
1/1 worked, retesting |
2/2 worked, retesting |
3/3 worked, retesting |
/cc @creydr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Thanks for fixing!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes knative#7021 This is the root cause: cloudevents/sdk-go#923 <!-- Please include the 'why' behind your changes if no issue exists --> <!-- Please categorize your changes: - 🎁 Add new feature - 🐛 Fix bug - 🧹 Update or clean up current behavior - 🗑️ Remove feature or internal logic --> - Re-enable PingSource TLS E2E test - Remove hacky client injection for PingSource <!-- If these boxes are not checked, you will be asked to complete these requirements or explain why they do not apply to your PR. --> - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** <!-- 📄 If this change has user-visible impact, write a release note in the block below. Include the string "action required" if additional action is required of users switching to the new release, for example in case of a breaking change. Write as if you are speaking to users, not other Knative contributors. If this change has no user-visible impact, no release note is needed. --> ```release-note ``` **Docs** <!-- 📖 If this change has user-visible impact, link to an issue or PR in https://github.com/knative/docs. --> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]>
Fixes knative#7021 This is the root cause: cloudevents/sdk-go#923 <!-- Please include the 'why' behind your changes if no issue exists --> <!-- Please categorize your changes: - 🎁 Add new feature - 🐛 Fix bug - 🧹 Update or clean up current behavior - 🗑️ Remove feature or internal logic --> - Re-enable PingSource TLS E2E test - Remove hacky client injection for PingSource <!-- If these boxes are not checked, you will be asked to complete these requirements or explain why they do not apply to your PR. --> - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** <!-- 📄 If this change has user-visible impact, write a release note in the block below. Include the string "action required" if additional action is required of users switching to the new release, for example in case of a breaking change. Write as if you are speaking to users, not other Knative contributors. If this change has no user-visible impact, no release note is needed. --> ```release-note ``` **Docs** <!-- 📖 If this change has user-visible impact, link to an issue or PR in https://github.com/knative/docs. --> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]>
Fixes #7021
This is the root cause: cloudevents/sdk-go#923
Proposed Changes
Pre-review Checklist
Release Note
Docs