Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventing TLS: Configure CRDs to have addresses and CA certs #7105

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

pierDipi
Copy link
Member

This adds addresses and CA certs to every CRDs

@knative-prow
Copy link

knative-prow bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from creydr and lberk July 25, 2023 10:17
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2023
@pierDipi
Copy link
Member Author

/cc @creydr @matzew

@knative-prow knative-prow bot requested a review from matzew July 25, 2023 10:17
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (6911db0) 78.34% compared to head (e420c35) 78.31%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7105      +/-   ##
==========================================
- Coverage   78.34%   78.31%   -0.03%     
==========================================
  Files         250      250              
  Lines       13320    13320              
==========================================
- Hits        10435    10432       -3     
- Misses       2355     2357       +2     
- Partials      530      531       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

/test upgrade-tests

6 similar comments
@pierDipi
Copy link
Member Author

/test upgrade-tests

@pierDipi
Copy link
Member Author

/test upgrade-tests

@pierDipi
Copy link
Member Author

/test upgrade-tests

@pierDipi
Copy link
Member Author

/test upgrade-tests

@pierDipi
Copy link
Member Author

/test upgrade-tests

@pierDipi
Copy link
Member Author

/test upgrade-tests

@knative-prow knative-prow bot merged commit 248a471 into knative:main Jul 26, 2023
21 of 24 checks passed
@pierDipi pierDipi deleted the cp-7b58aaf71-main branch July 26, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants