Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edit role aggregation #7124

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix edit role aggregation #7124

merged 1 commit into from
Jul 31, 2023

Conversation

creydr
Copy link
Member

@creydr creydr commented Jul 31, 2023 •
edited
Loading

Fix view role aggregation

Fix of the rule aggregation of the `knative-eventing-namespaced-edit` role to only give view permissions on knative eventing resources.

@knative-prow knative-prow bot requested review from matzew and pierDipi July 31, 2023 08:37
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2023
@creydr
Copy link
Member Author

creydr commented Jul 31, 2023

/assign @matzew @maschmid @pierDipi

matzew
matzew approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member Author

creydr commented Jul 31, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@creydr: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@creydr
Copy link
Member Author

creydr commented Jul 31, 2023

/cherry-pick release-1.10

@knative-prow-robot
Copy link
Contributor

@creydr: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

pierDipi commented Jul 31, 2023 •
edited
Loading

@creydr can we get a release note text here?

@creydr
Copy link
Member Author

creydr commented Jul 31, 2023

@creydr can we get a release note text here?

Updated

/easy-cla

@creydr
Copy link
Member Author

creydr commented Jul 31, 2023

/check-cla

1 similar comment
@creydr
Copy link
Member Author

creydr commented Jul 31, 2023

/check-cla

@krsna-m
Copy link

krsna-m commented Jul 31, 2023

/easycla

@knative-prow knative-prow bot merged commit 694ae3e into knative:main Jul 31, 2023
21 of 23 checks passed
@knative-prow-robot knative-prow-robot mentioned this pull request Jul 31, 2023
Merged
@knative-prow-robot
Copy link
Contributor

@creydr: new pull request created: #7128

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Jul 31, 2023
Merged
@knative-prow-robot
Copy link
Contributor

@creydr: new pull request created: #7129

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow bot pushed a commit that referenced this pull request Aug 1, 2023
@knative-prow-robot @creydr
[release-1.10] Fix edit role aggregation (#7129)
1b3281e 
This is an automated cherry-pick of #7124

```release-note
Fix of the rule aggregation of the `knative-eventing-namespaced-edit` role to only give view permissions on knative eventing resources.
```

Co-authored-by: Christoph Stäbler <[email protected]>
knative-prow bot pushed a commit that referenced this pull request Aug 1, 2023
@knative-prow-robot @creydr
[release-1.11] Fix edit role aggregation (#7128)
cf146f1 
This is an automated cherry-pick of #7124

```release-note
Fix of the rule aggregation of the `knative-eventing-namespaced-edit` role to only give view permissions on knative eventing resources.
```

Co-authored-by: Christoph Stäbler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@matzew matzew

@maschmid maschmid

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@creydr @knative-prow-robot @pierDipi @krsna-m @matzew @maschmid