Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retryAfter experimental e2e test #7148

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 4, 2023

After knative-extensions/reconciler-test#535 and thus distinguishing between received/rejected events, the ReplyAfter e2e test needs to be adjusted.
Currently it fails due to

 - Match errors -
0 - event kind don't match. Expected: 'Sent', Actual: 'Rejected'
1 - event kind don't match. Expected: 'Sent', Actual: 'Rejected'
2 - event kind don't match. Expected: 'Sent', Actual: 'Rejected'

and later

- Match errors -
0 - response received at 2023-08-03 14:33:17.338149413 +0000 UTC, it should have waited until 2023-08-03 14:33:41.369616997 +0000 UTC

as it is not differentiated between received and rejected events.

This PR addresses it and adjust the event matchers.

@knative-prow
Copy link

knative-prow bot commented Aug 4, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2023
@creydr
Copy link
Member Author

creydr commented Aug 4, 2023

/test all

@knative-prow knative-prow bot added area/test-and-release Test infrastructure, tests or release size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8a90e40) 77.92% compared to head (a9f726a) 77.92%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7148   +/-   ##
=======================================
  Coverage   77.92%   77.92%           
=======================================
  Files         248      248           
  Lines       13257    13257           
=======================================
  Hits        10330    10330           
  Misses       2400     2400           
  Partials      527      527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Member Author

creydr commented Aug 4, 2023

@creydr creydr marked this pull request as ready for review August 4, 2023 10:00
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2023
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 37a5651 into knative:main Aug 4, 2023
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants