-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix retryAfter experimental e2e test #7148
Conversation
Skipping CI for Draft Pull Request. |
/test all |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7148 +/- ##
=======================================
Coverage 77.92% 77.92%
=======================================
Files 248 248
Lines 13257 13257
=======================================
Hits 10330 10330
Misses 2400 2400
Partials 527 527 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After knative-extensions/reconciler-test#535 and thus distinguishing between received/rejected events, the ReplyAfter e2e test needs to be adjusted.
Currently it fails due to
and later
as it is not differentiated between received and rejected events.
This PR addresses it and adjust the event matchers.