support auto generation of Sequence identity service account [OIDC]

[rahulii]

Fixes #7224

Proposed Changes

• 🎁 Expose the name of the OIDC service account in the Sequence .status.auth.serviceAccountName
• 🎁 Create the OIDC service account of the Sequence

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

Expose the Sequence OIDC service account name in the Sequence .status.auth.serviceAccountName after created Service Account.

[knative-prow]

Hi @rahulii. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rahulii]

Unit Tests are WIP!

[creydr]

@rahulii thanks for your contribution so far. Let me know, when this PR is ready for review

[creydr]

Hi @rahulii,
any updates on this?

[Leo6Leo]

Hey @rahulii Are you being blocked by anything? Feel free to share any issues that you are encountering

[creydr]

As I couldn't commit to this branch, I added #7434 which adds the tests as well.

[creydr]

@rahulii I also created rahulii#1 which adds the unit tests to your branch. Could you PTAL?

[codecov]

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (f321ba5) 76.86% compared to head (077f701) 76.73%.
Report is 37 commits behind head on main.

Files	Patch %	Lines
pkg/apis/flows/v1/sequence_lifecycle.go	25.00%	6 Missing ⚠️
pkg/reconciler/sequence/controller.go	82.75%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7361      +/-   ##
==========================================
- Coverage   76.86%   76.73%   -0.13%     
==========================================
  Files         252      253       +1     
  Lines       13727    13963     +236     
==========================================
+ Hits        10551    10715     +164     
- Misses       2650     2712      +62     
- Partials      526      536      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[creydr]

/ok-to-test

[creydr]

/test upgrade-tests

[creydr]

Thanks a lot @rahulii for this PR. I have only one comment, which would be great if we could solve this before merging.

[creydr]

$ kubectl get sequence sequence -o yaml              
apiVersion: flows.knative.dev/v1
kind: Sequence
metadata:
  name: sequence
  namespace: default
  resourceVersion: "2910"
  uid: 93f23f3d-08ab-41bd-a524-354ae23d7110
spec:
  channelTemplate:
    apiVersion: messaging.knative.dev/v1
    kind: InMemoryChannel
  reply:
    ref:
      apiVersion: serving.knative.dev/v1
      kind: Service
      name: event-display
      namespace: default
  steps:
  - ref:
      apiVersion: serving.knative.dev/v1
      kind: Service
      name: first
      namespace: default
  - ref:
      apiVersion: serving.knative.dev/v1
      kind: Service
      name: second
      namespace: default
status:
  auth:
    serviceAccountName: oidc-flows.knative.dev-sequence-sequence
  ...

✔️

Thanks a lot @rahulii for your patience and finishing the last mile 👍

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, rahulii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [creydr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment