-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support auto generation of Sequence identity service account [OIDC] #7361
Conversation
Signed-off-by: rahulii <[email protected]>
Hi @rahulii. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Unit Tests are WIP! |
@rahulii thanks for your contribution so far. Let me know, when this PR is ready for review |
Hi @rahulii, |
Hey @rahulii Are you being blocked by anything? Feel free to share any issues that you are encountering |
As I couldn't commit to this branch, I added #7434 which adds the tests as well. |
Add unit tests for sequence OIDC service account creation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7361 +/- ##
==========================================
- Coverage 76.86% 76.73% -0.13%
==========================================
Files 252 253 +1
Lines 13727 13963 +236
==========================================
+ Hits 10551 10715 +164
- Misses 2650 2712 +62
- Partials 526 536 +10 ☔ View full report in Codecov by Sentry. |
/ok-to-test |
/test upgrade-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @rahulii for this PR. I have only one comment, which would be great if we could solve this before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ kubectl get sequence sequence -o yaml
apiVersion: flows.knative.dev/v1
kind: Sequence
metadata:
name: sequence
namespace: default
resourceVersion: "2910"
uid: 93f23f3d-08ab-41bd-a524-354ae23d7110
spec:
channelTemplate:
apiVersion: messaging.knative.dev/v1
kind: InMemoryChannel
reply:
ref:
apiVersion: serving.knative.dev/v1
kind: Service
name: event-display
namespace: default
steps:
- ref:
apiVersion: serving.knative.dev/v1
kind: Service
name: first
namespace: default
- ref:
apiVersion: serving.knative.dev/v1
kind: Service
name: second
namespace: default
status:
auth:
serviceAccountName: oidc-flows.knative.dev-sequence-sequence
...
✔️
Thanks a lot @rahulii for your patience and finishing the last mile 👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, rahulii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…[OIDC] (knative#7361)" This reverts commit e5f2814.
…[OIDC] (knative#7361)" This reverts commit e5f2814.
…#7902) * Update CRDs to include AuthStatus serviceAccountNames * Revert "support auto generation of Sequence identity service account [OIDC] (#7361)" This reverts commit e5f2814. * Update Sequence to expose OIDC identities of underlying Subscriptions * Revert "Add serviceaccount in parallel (#7373)" This reverts commit dc96522. * Update Parallel to expose OIDC identities of underlying Subscriptions * Add e2e test for Parallel * Add e2e test for Sequence * Add unit tests
Fixes #7224
Proposed Changes
Pre-review Checklist
Release Note