Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serviceaccount in parallel #7373

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Add serviceaccount in parallel #7373

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4c779f4
added serviceaccount in parallel
prakrit55 Oct 17, 2023
6ea07fb
Update controller.go
prakrit55 Oct 17, 2023
fd0b0cd
Update controller.go
prakrit55 Oct 17, 2023
b2f2372
added Marker functions and tests
prakrit55 Oct 17, 2023
fe85dfb
added tests
prakrit55 Oct 28, 2023
fc49ab8
Merge branch 'knative:main' into feature/serviceaccount-in-parallel
prakrit55 Oct 28, 2023
96a68f5
added function in test and fixed lint
prakrit55 Nov 11, 2023
92ca6c2
fixing test in parallel_test
prakrit55 Nov 16, 2023
4798fce
fixed lint
prakrit55 Nov 16, 2023
dc92aa1
modified parallel_test
prakrit55 Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions pkg/reconciler/parallel/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,7 @@ func NewController(
subscriptionInformer := subscription.Get(ctx)
serviceaccountInformer := serviceaccountinformer.Get(ctx)

var globalResync func(obj interface{})
featureStore := feature.NewStore(logging.FromContext(ctx).Named("feature-config-store"), func(name string, value interface{}) {
if globalResync != nil {
globalResync(nil)
}
})
creydr marked this conversation as resolved.
Show resolved Hide resolved
featureStore := feature.NewStore(logging.FromContext(ctx).Named("feature-config-store"))
featureStore.WatchConfigs(cmw)

r := &Reconciler{
Expand All @@ -64,7 +59,11 @@ func NewController(
dynamicClientSet: dynamicclient.Get(ctx),
eventingClientSet: eventingclient.Get(ctx),
}
impl := parallelreconciler.NewImpl(ctx, r)
impl := parallelreconciler.NewImpl(ctx, r, func(impl *controller.Impl) controller.Options {
return controller.Options{
ConfigStore: featureStore,
}
})

r.channelableTracker = duck.NewListableTrackerFromTracker(ctx, channelable.Get, impl.Tracker)
parallelInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))
Expand All @@ -75,7 +74,7 @@ func NewController(
FilterFunc: controller.FilterController(&v1.Parallel{}),
Handler: controller.HandleAll(impl.EnqueueControllerOf),
})
// Reconciler Trigger when the OIDC service account changes
// Reconciler Parallel when the OIDC service account changes
prakrit55 marked this conversation as resolved.
Show resolved Hide resolved
serviceaccountInformer.Informer().AddEventHandler(cache.FilteringResourceEventHandler{
FilterFunc: controller.FilterController(&v1.Parallel{}),
Handler: controller.HandleAll(impl.EnqueueControllerOf),
Expand Down