Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move new trigger tests to conformance suite #7626

Closed
wants to merge 1 commit into from
Closed

Move new trigger tests to conformance suite #7626

wants to merge 1 commit into from

Conversation

Cali0707
Copy link
Member

Fixes #7625

Proposed Changes

  • Move new trigger filter tests to conformance
  • Update conformance main to use parsed rest config and pass it to the reconciler-test global environment

@knative-prow knative-prow bot requested review from lberk and mgencur January 24, 2024 18:30
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Jan 24, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Jan 24, 2024 •
edited
Loading

/hold
This required changes to reconciler-test vendor code to get the tests to run, so I need to merge a fix there first and rebase this PR. This just includes those changes to see why they are needed

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@Cali0707 Cali0707 requested review from creydr and pierDipi and removed request for mgencur and lberk January 24, 2024 18:31
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0d9c13) 74.54% compared to head (8cb9fb4) 74.44%.
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7626      +/-   ##
==========================================
- Coverage   74.54%   74.44%   -0.11%     
==========================================
  Files         262      262              
  Lines       14965    15077     +112     
==========================================
+ Hits        11156    11224      +68     
- Misses       3219     3247      +28     
- Partials      590      606      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 24, 2024

@Cali0707: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build-tests_eventing_main 8cb9fb4 link true /test build-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Cali0707 Cali0707 mentioned this pull request Jan 24, 2024
Merged
pierDipi
pierDipi reviewed Jan 25, 2024
View reviewed changes
test/conformance/main_test.go
Comment on lines +73 to +77
cfg, err := pkgtest.Flags.GetRESTConfig()
if err != nil {
panic("failed to get rest config")
}
global = environment.NewGlobalEnvironmentWithRestConfig(cfg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the new rekt-based conformance tests ? https://github.com/knative/eventing/blob/ab47824bebe4211a046ebdd50163e935963a6831/test/rekt/features/broker/data_plane.go#L31C6-L31C26

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This other conformance suite is limited and it will not evolve anymore until we can remove it

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2024
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

@Cali0707 any updates on this one?

@Cali0707
Copy link
Member Author

@Cali0707 any updates on this one?

@pierDipi I held off on updating this one since we decided that the filters wouldn't go GA until the CESQL stuff reaches a more stable spec version. I'll close this for now, and open a new one when that happens

@Cali0707 Cali0707 closed this Mar 26, 2024
@Cali0707 Cali0707 mentioned this pull request Sep 9, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi left review comments

@creydr creydr Awaiting requested review from creydr

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Event Filtering: Move tests to conformance
3 participants
@Cali0707 @knative-prow-robot @pierDipi