-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move new trigger tests to conformance suite #7626
Move new trigger tests to conformance suite #7626
Conversation
Signed-off-by: Calum Murray <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7626 +/- ##
==========================================
- Coverage 74.54% 74.44% -0.11%
==========================================
Files 262 262
Lines 14965 15077 +112
==========================================
+ Hits 11156 11224 +68
- Misses 3219 3247 +28
- Partials 590 606 +16 ☔ View full report in Codecov by Sentry. |
@Cali0707: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
cfg, err := pkgtest.Flags.GetRESTConfig() | ||
if err != nil { | ||
panic("failed to get rest config") | ||
} | ||
global = environment.NewGlobalEnvironmentWithRestConfig(cfg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the new rekt-based conformance tests ? https://github.com/knative/eventing/blob/ab47824bebe4211a046ebdd50163e935963a6831/test/rekt/features/broker/data_plane.go#L31C6-L31C26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This other conformance suite is limited and it will not evolve anymore until we can remove it
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Cali0707 any updates on this one? |
Fixes #7625
Proposed Changes