Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate configMaps #7847

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

ckcd
Copy link
Contributor

@ckcd ckcd commented Apr 19, 2024

Fixes #7809

Proposed Changes

  • 🐛 remove redundant config-observability and config-tracing config maps for in-memory-channel.

Release Note

No

Docs

No documentation changes required I think.

@knative-prow knative-prow bot requested review from aslom and matzew April 19, 2024 06:52
@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2024
Copy link

knative-prow bot commented Apr 19, 2024

Hi @ckcd. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Cali0707
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2024
@Cali0707
Copy link
Member

/cc @pierDipi @creydr

I’m not familiar enough with what these are used for to know if we can remove or not

@knative-prow knative-prow bot requested review from creydr and pierDipi April 19, 2024 07:28
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.55%. Comparing base (7e1c082) to head (de0a1b1).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7847      +/-   ##
==========================================
+ Coverage   69.22%   69.55%   +0.33%     
==========================================
  Files         339      340       +1     
  Lines       19494    15726    -3768     
==========================================
- Hits        13494    10938    -2556     
+ Misses       5337     4121    -1216     
- Partials      663      667       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ckcd

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
Copy link

knative-prow bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckcd, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

/test reconciler-tests

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@knative-prow knative-prow bot merged commit ea14296 into knative:main Apr 23, 2024
28 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant definition of config maps from generated YAML files
3 participants