Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fish completion #151

Merged
merged 2 commits into from
Oct 6, 2020
Merged

feat: fish completion #151

merged 2 commits into from
Oct 6, 2020

Conversation

matejvasek
Copy link
Contributor

No description provided.

@matejvasek
Copy link
Contributor Author

related spf13/cobra#1247

zroubalik
zroubalik approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matejvasek
Copy link
Contributor Author

To make this work on fish version 3.0 we need to update the cobra dependency. @rhuss could it cause any problems in relation to kn package?

@matejvasek matejvasek merged commit d822303 into knative:main Oct 6, 2020
@rhuss
Copy link
Contributor

rhuss commented Oct 14, 2020

Sorry for the late reply :) I don't expect any issues with the cobra dependency as cobra is movin very slowly anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @rhuss @zroubalik