Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the image overriding issue for Jobs #1554

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

houshengbo
Copy link
Contributor

Fixes: #1553

@knative-prow knative-prow bot requested review from aliok and matzew September 7, 2023 14:14
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (95b0179) 79.25% compared to head (766c825) 79.25%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1554   +/-   ##
=======================================
  Coverage   79.25%   79.25%           
=======================================
  Files          40       40           
  Lines        1822     1822           
=======================================
  Hits         1444     1444           
  Misses        275      275           
  Partials      103      103           
Files Changed Coverage Δ
pkg/reconciler/common/images.go 78.40% <100.00%> (ø)
pkg/reconciler/common/transformers.go 82.60% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houshengbo houshengbo changed the title Fixed the image overriding issue Fixed the image overriding issue for Jobs Sep 7, 2023
@dprotaso
Copy link
Member

dprotaso commented Sep 7, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,houshengbo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3d8c3fb into knative:main Sep 7, 2023
17 checks passed
@houshengbo
Copy link
Contributor Author

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@houshengbo: new pull request created: #1555

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image overriding for Jobs does not function
3 participants