Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter "control-plane" labeled namespaces out of our webhooks #1592

Merged
merged 3 commits into from
Aug 7, 2020
Merged

filter "control-plane" labeled namespaces out of our webhooks #1592

merged 3 commits into from
Aug 7, 2020

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Aug 6, 2020

fixes: #1590

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 6, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 6, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
webhook/resourcesemantics/defaulting/defaulting.go 87.4% 86.7% -0.7
webhook/resourcesemantics/validation/reconcile_config.go 91.7% 89.6% -2.1

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 6, 2020
@n3wscott
Copy link
Contributor Author

n3wscott commented Aug 6, 2020

/retest

evankanderson
evankanderson reviewed Aug 7, 2020
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold

In case you want to add a comment.

webhook/resourcesemantics/defaulting/defaulting.go Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2020
evankanderson
evankanderson reviewed Aug 7, 2020
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
/lgtm

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 7, 2020
@evankanderson
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@n3wscott
Copy link
Contributor Author

n3wscott commented Aug 7, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 7b92ffa into knative:master Aug 7, 2020
@dhemeier dhemeier mentioned this pull request Mar 10, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson left review comments

@dprotaso dprotaso Awaiting requested review from dprotaso

@tcnghia tcnghia Awaiting requested review from tcnghia

@whaught whaught Awaiting requested review from whaught

Assignees

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Knative is unable to be deployed to Azure Kubernetes Service 1.17+
6 participants
@n3wscott @knative-metrics-robot @evankanderson @knative-prow-robot @dprotaso @googlebot