Skip to content

Commit

Permalink
Review
Browse files Browse the repository at this point in the history
  • Loading branch information
Tara Gu committed Feb 21, 2020
1 parent 317b902 commit 40791d8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/reconciler/configuration/configuration.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,9 @@ func (c *Reconciler) getSortedCreatedRevisions(ctx context.Context, config *v1.C
lrr, err := lister.Get(config.Status.LatestReadyRevisionName)
// Record the error and continue because we still want to set the LRR to the correct revision.
if err != nil {
// If the user deletes the LatestReadyRevision then this may return an error due to the
// dangling reference. Proceed to calculate the next-latest ready revision so that the
// caller can synthesize a new Revision at the current generation to replace the one deleted.
logger.Errorf("Error getting latest ready revision %q: %v", config.Status.LatestReadyRevisionName, err)
} else {
start := lrr.Generation
Expand Down

0 comments on commit 40791d8

Please sign in to comment.