Skip to content

Commit

Permalink
see what fails
Browse files Browse the repository at this point in the history
  • Loading branch information
dprotaso committed Jan 15, 2024
1 parent 05b640b commit 8e0535d
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions pkg/reconciler/revision/resources/pa.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

"knative.dev/pkg/apis"
"knative.dev/pkg/kmeta"
autoscalingv1alpha1 "knative.dev/serving/pkg/apis/autoscaling/v1alpha1"
v1 "knative.dev/serving/pkg/apis/serving/v1"
Expand Down Expand Up @@ -52,16 +51,16 @@ func MakePA(rev *v1.Revision) *autoscalingv1alpha1.PodAutoscaler {

func reachability(rev *v1.Revision) autoscalingv1alpha1.ReachabilityType {
// check infra failures
conds := []apis.ConditionType{
v1.RevisionConditionResourcesAvailable,
v1.RevisionConditionContainerHealthy,
}
// conds := []apis.ConditionType{
// v1.RevisionConditionResourcesAvailable,
// v1.RevisionConditionContainerHealthy,
// }

for _, cond := range conds {
if c := rev.Status.GetCondition(cond); c != nil && c.IsFalse() {
return autoscalingv1alpha1.ReachabilityUnreachable
}
}
// for _, cond := range conds {
// if c := rev.Status.GetCondition(cond); c != nil && c.IsFalse() {
// return autoscalingv1alpha1.ReachabilityUnreachable
// }
// }

switch rev.GetRoutingState() {
case v1.RoutingStateActive:
Expand Down

0 comments on commit 8e0535d

Please sign in to comment.