Review

knative · Feb 20, 2020 · 8fafe73 · 8fafe73
1 parent b4f0dff
commit 8fafe73
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/pkg/reconciler/configuration/configuration.go b/pkg/reconciler/configuration/configuration.go
@@ -153,7 +153,7 @@ func (c *Reconciler) getSortedCreatedRevisions(ctx context.Context, config *v1.C
 	})
 	if config.Status.LatestReadyRevisionName != "" {
 		lrr, err := lister.Get(config.Status.LatestReadyRevisionName)
-		// Record the error and continue because we still want to set the LRR to the correct revision
+		// Record the error and continue because we still want to set the LRR to the correct revision.
 		if err != nil {
 			logger.Errorf("Error getting latest ready revision %q: %v", config.Status.LatestReadyRevisionName, err)
 		} else {
@@ -170,10 +170,9 @@ func (c *Reconciler) getSortedCreatedRevisions(ctx context.Context, config *v1.C
 				selection.In,
 				generations,
 			)
-			if err != nil {
-				return nil, err
+			if err == nil {
+				configSelector = configSelector.Add(*inReq)
 			}
-			configSelector = configSelector.Add(*inReq)
 		}
 	}