Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panicRPSM parameter in autoscaler is set to observedStableValue instead of observedPanicValue #12909

Closed
Nalin28 opened this issue May 4, 2022 · 1 comment · Fixed by #12910
Closed

panicRPSM parameter in autoscaler is set to observedStableValue instead of observedPanicValue #12909

Nalin28 opened this issue May 4, 2022 · 1 comment · Fixed by #12910
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)
Milestone
v1.5.0

Comments

@Nalin28
Copy link
Contributor

Nalin28 commented May 4, 2022 •
edited
Loading

What version of Knative?

0.9.x
0.10.x
0.11.x
Output of git describe --dirty

Expected Behavior

panicRPSM parameter in autoscaler should be observedPanicValue.

Actual Behavior

panicRPSM parameter in autoscaler is set to observedStableValue instead of observedPanicValue.

Steps to Reproduce the Problem

[]
bug present in pkg/autoscaler/scaling/autoscaler.go
@Nalin28 Nalin28 added the kind/bug Categorizes issue or PR as related to a bug. label May 4, 2022
@dprotaso dprotaso mentioned this issue May 4, 2022
Merged
@dprotaso dprotaso added this to the v1.5.0 milestone May 4, 2022
@dprotaso
Copy link
Member

dprotaso commented May 4, 2022

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

Fixing the panicRPSM parameter in autoscaler ubc-cirrus-lab/serving-1
2 participants
@dprotaso @Nalin28