Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the panicRPSM parameter in autoscaler #12910

Merged
merged 2 commits into from
May 4, 2022

Conversation

Nalin28
Copy link
Contributor

@Nalin28 Nalin28 commented May 4, 2022

The value of panicRPSM was set as observedStableValue, but it should have been observedPanicValue.

Fixes #12909

Proposed Changes

Changed panicRPSM.M(observedStableValue) to panicRPSM.M(observedPanicValue) in autoscaler.

Release Note

The value of panicRPSM was set as observedStableValue, but it should have been observedPanicValue as part of the metric collection.

The value of panicRPSM was set as observedStableValue, but it should have been observedPanicValue.
@google-cla
Copy link

google-cla bot commented May 4, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/autoscale labels May 4, 2022
@knative-prow
Copy link

knative-prow bot commented May 4, 2022

Hi @Nalin28. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 4, 2022
@nader-ziada
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 4, 2022
@Nalin28
Copy link
Contributor Author

Nalin28 commented May 4, 2022

/retest

@evankanderson
Copy link
Member

/assign @nader-ziada

If needed, /assign to me as well for approval, but I'm hoping to get Nader that power-up soon. 😁

@evankanderson
Copy link
Member

/retest

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #12910 (6bae505) into main (7aa5d8a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #12910      +/-   ##
==========================================
- Coverage   87.04%   87.03%   -0.02%     
==========================================
  Files         197      197              
  Lines       14437    14437              
==========================================
- Hits        12567    12565       -2     
- Misses       1576     1578       +2     
  Partials      294      294              
Impacted Files Coverage Δ
pkg/autoscaler/scaling/autoscaler.go 98.35% <100.00%> (ø)
pkg/reconciler/revision/reconcile_resources.go 80.80% <0.00%> (-2.41%) ⬇️
pkg/activator/net/revision_backends.go 92.19% <0.00%> (-0.58%) ⬇️
pkg/reconciler/revision/background.go 92.72% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa5d8a...6bae505. Read the comment docs.

Copy link
Member

@nader-ziada nader-ziada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Nalin28

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2022
@dprotaso
Copy link
Member

dprotaso commented May 4, 2022

/approve

🎉 thanks for the fix

@knative-prow
Copy link

knative-prow bot commented May 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nader-ziada, Nalin28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@knative-prow knative-prow bot merged commit 061be9e into knative:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panicRPSM parameter in autoscaler is set to observedStableValue instead of observedPanicValue
4 participants