-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the panicRPSM parameter in autoscaler #12910
Conversation
The value of panicRPSM was set as observedStableValue, but it should have been observedPanicValue.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Hi @Nalin28. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
/assign @nader-ziada If needed, |
/retest |
Codecov Report
@@ Coverage Diff @@
## main #12910 +/- ##
==========================================
- Coverage 87.04% 87.03% -0.02%
==========================================
Files 197 197
Lines 14437 14437
==========================================
- Hits 12567 12565 -2
- Misses 1576 1578 +2
Partials 294 294
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Nalin28
/lgtm
/approve 🎉 thanks for the fix |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, nader-ziada, Nalin28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The value of panicRPSM was set as observedStableValue, but it should have been observedPanicValue.
Fixes #12909
Proposed Changes
Changed panicRPSM.M(observedStableValue) to panicRPSM.M(observedPanicValue) in autoscaler.
Release Note