Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RevisionSpec is missing timeoutSeconds #457

Closed
mattmoor opened this issue Mar 22, 2018 · 7 comments
Closed

RevisionSpec is missing timeoutSeconds #457

mattmoor opened this issue Mar 22, 2018 · 7 comments
Assignees
@k4leung4
Labels
area/API API objects and controllers area/networking kind/feature Well-understood/specified features, ready for coding.
Milestone
0.3.x

Comments

@mattmoor
Copy link
Member

From: #444

# +optional. max time the instance is allowed for responding to a request
timeoutSeconds: ...

This field is missing here. I suspect we need something in the request path (e.g. ela-queue) that can enforce this.

@josephburnett @mdemirhan WDYT?

cc @cooperneil @bobcatfish
@mattmoor mattmoor added kind/feature Well-understood/specified features, ready for coding. area/API API objects and controllers area/networking labels Mar 22, 2018
@mdemirhan
Copy link
Contributor

ela-queue is something we want to retire ideally and just rely on Envoy doing all proxying for us. Might be a good idea to try and implement this in istio if possible.

@mdemirhan mdemirhan mentioned this issue Mar 22, 2018
Closed
@mattmoor mattmoor mentioned this issue Apr 11, 2018
Closed
@bobcatfish
Copy link
Contributor

Whoever works on this please ping me re. adding this to the conformance tests :D

@tcnghia
Copy link
Contributor

tcnghia commented Apr 18, 2018

dup #487

@tcnghia tcnghia closed this as completed Apr 18, 2018
@tcnghia tcnghia mentioned this issue Jul 24, 2018
Merged
@mattmoor mattmoor mentioned this issue Aug 8, 2018
Closed
@mattmoor mattmoor mentioned this issue Oct 31, 2018
Closed
@mattmoor mattmoor reopened this Oct 31, 2018
@mattmoor
Copy link
Member Author

/assign @k4leung4

@knative-prow-robot
Copy link
Contributor

@mattmoor: GitHub didn't allow me to assign the following users: k4leung4.

Note that only knative members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @k4leung4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k4leung4
Copy link
Contributor

/assign

@tcnghia
Copy link
Contributor

tcnghia commented Nov 6, 2018

dup #2201

@tcnghia tcnghia closed this as completed Nov 6, 2018
@tcnghia tcnghia reopened this Nov 6, 2018
k4leung4 added a commit to k4leung4/serving that referenced this issue Nov 8, 2018
@k4leung4
Add timeoutSeconds ot RevisionSpec
3c48ecf 
re: issue: knative#457
Set default timeout to 60 seconds.
Will implement the enforcement of the timeout in future PR.
k4leung4 added a commit to k4leung4/serving that referenced this issue Nov 8, 2018
@k4leung4
Add timeoutSeconds ot RevisionSpec
0018a4e 
re: issue: knative#457
Set default timeout to 60 seconds.
Will implement the enforcement of the timeout in future PR.
k4leung4 added a commit to k4leung4/serving that referenced this issue Nov 8, 2018
@k4leung4
Add timeoutSeconds ot RevisionSpec
238606f 
re: issue: knative#457
Set default timeout to 60 seconds.
Will implement the enforcement of the timeout in future PR.
@k4leung4 k4leung4 mentioned this issue Nov 8, 2018
Merged
k4leung4 added a commit to k4leung4/serving that referenced this issue Nov 9, 2018
@k4leung4
Add timeoutSeconds to RevisionSpec
dc846b1 
re: issue: knative#457
Set revisionspec default timeout to 60 seconds.
Add max timeout for cluster ingress at 300 seconds.
Add checks that cluster ingress timeout and revisionspec timeout does
not exceed cluster ingress max timeout.

Will implement the enforcement of the timeout in future PR.
k4leung4 added a commit to k4leung4/serving that referenced this issue Nov 9, 2018
@k4leung4
Add timeoutSeconds to RevisionSpec
caa548e 
re: issue: knative#457
Set revisionspec default timeout to 60 seconds.
Add max timeout for cluster ingress at 300 seconds.
Add checks that cluster ingress timeout and revisionspec timeout does
not exceed cluster ingress max timeout.

Will implement the enforcement of the timeout in future PR.
k4leung4 added a commit to k4leung4/serving that referenced this issue Nov 13, 2018
@k4leung4
Add timeoutSeconds to RevisionSpec
c338531 
re: issue: knative#457
Set revisionspec default timeout to 60 seconds.
Add max timeout for cluster ingress at 300 seconds.
Add checks that cluster ingress timeout and revisionspec timeout does
not exceed cluster ingress max timeout.

Will implement the enforcement of the timeout in future PR.
k4leung4 added a commit to k4leung4/serving that referenced this issue Nov 14, 2018
@k4leung4
Add timeoutSeconds to RevisionSpec
2b198e0 
re: issue: knative#457
Use ClusterIngress default timeout as max timeout for revisionspec.
Add checks that cluster ingress timeout and revisionspec timeout does
not exceed cluster ingress default timeout.

Will implement the enforcement of the timeout in future PR.
k4leung4 added a commit to k4leung4/serving that referenced this issue Nov 14, 2018
@k4leung4
Add timeoutSeconds to RevisionSpec
dd27934 
re: issue: knative#457
Use ClusterIngress default timeout as max timeout for revisionspec.
Add checks that cluster ingress timeout and revisionspec timeout does
not exceed cluster ingress default timeout.

Will implement the enforcement of the timeout in future PR.
knative-prow-robot pushed a commit that referenced this issue Nov 15, 2018
@k4leung4 @knative-prow-robot
Add timeoutSeconds to RevisionSpec (#2437)
c92a249 
* Add timeoutSeconds to RevisionSpec

re: issue: #457
Use ClusterIngress default timeout as max timeout for revisionspec.
Add checks that cluster ingress timeout and revisionspec timeout does
not exceed cluster ingress default timeout.

Will implement the enforcement of the timeout in future PR.

* Pulling in a new knative/pkg to pick up ErrOutOfBoundsValue helper
k4leung4 added a commit to k4leung4/serving that referenced this issue Nov 19, 2018
@k4leung4
Have queue-proxy enforce revisiontimeout
4e7a2e3 
Pass RevisionTimeoutSeconds down to queue-proxy and have it timeout
requests basd on RevisionTimeoutSeconds.
knative#457

Add conformance test to ensure request timeouts are handled.
knative#1818
k4leung4 added a commit to k4leung4/serving that referenced this issue Nov 19, 2018
@k4leung4
Have queue-proxy enforce revisiontimeout
996e186 
Pass RevisionTimeoutSeconds down to queue-proxy and have it timeout
requests basd on RevisionTimeoutSeconds.
knative#457

Add conformance test to ensure request timeouts are handled.
knative#1818
@k4leung4 k4leung4 mentioned this issue Nov 19, 2018
Merged
k4leung4 added a commit to k4leung4/serving that referenced this issue Nov 20, 2018
@k4leung4
Have queue-proxy enforce revisiontimeout
87cb6e6 
Pass RevisionTimeoutSeconds down to queue-proxy and have it timeout
requests basd on RevisionTimeoutSeconds.
knative#457

Add conformance test to ensure request timeouts are handled.
knative#1818
k4leung4 added a commit to k4leung4/serving that referenced this issue Nov 20, 2018
@k4leung4
Have queue-proxy enforce revisiontimeout
1b93cc0 
Pass RevisionTimeoutSeconds down to queue-proxy and have it timeout
requests basd on RevisionTimeoutSeconds.
knative#457

Add conformance test to ensure request timeouts are handled.
knative#1818
@mattmoor mattmoor modified the milestone: Serving 0.3 Nov 20, 2018
knative-prow-robot pushed a commit that referenced this issue Nov 20, 2018
@k4leung4 @knative-prow-robot
Have queue-proxy enforce revisiontimeout (#2522)
1f7c59e 
Pass RevisionTimeoutSeconds down to queue-proxy and have it timeout
requests basd on RevisionTimeoutSeconds.
#457

Add conformance test to ensure request timeouts are handled.
#1818
skonto added a commit to skonto/serving that referenced this issue Oct 12, 2023
@skonto
remove sec profile from queue proxy (knative#457)
b2cb758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k4leung4 k4leung4

Labels
area/API API objects and controllers area/networking kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Milestone
0.3.x
Development

No branches or pull requests
6 participants
@tcnghia @bobcatfish @mattmoor @mdemirhan @k4leung4 @knative-prow-robot