Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activator: Deal with multiple ports when proxy requests. #837

Closed
akyyy opened this issue May 8, 2018 · 1 comment
Closed

Activator: Deal with multiple ports when proxy requests. #837

akyyy opened this issue May 8, 2018 · 1 comment
Labels
area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding.

Comments

@akyyy
Copy link
Contributor

akyyy commented May 8, 2018

/area autoscale
/area test-and-release

/kind dev

Expected Behavior

It's possible that the target service has more than one ports. E.g. when we enable mutual TLS, we might need to add a second port for health checks, separate from the serving port.

Actual Behavior

Currently activator assumes there is only one port for the target revision.

Additional Info
@google-prow-robot google-prow-robot added area/autoscale area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding. labels May 8, 2018
@akyyy akyyy mentioned this issue May 8, 2018
Closed
@markusthoemmes
Copy link
Contributor

Could we solve this by making the name of the service port (today: "http") a constant and search for that port rather than relying on there only being one port?

markusthoemmes added a commit to markusthoemmes/knative-serving that referenced this issue Aug 21, 2018
@markusthoemmes
Allow the activator to deal with multiple service ports.
d06aeba 
The activator today assumes that a service has exactly one port. An unnecessary restriction.

This exposes a well-known port per service and allows the activator to deal with an arbitrary number of ports on the service side as long as the well-known port exists at least.

Fixes knative#837
@markusthoemmes markusthoemmes mentioned this issue Aug 21, 2018
Merged
markusthoemmes added a commit to markusthoemmes/knative-serving that referenced this issue Sep 4, 2018
@markusthoemmes
Allow the activator to deal with multiple service ports.
bdaf5c9 
The activator today assumes that a service has exactly one port. An unnecessary restriction.

This exposes a well-known port per service and allows the activator to deal with an arbitrary number of ports on the service side as long as the well-known port exists at least.

Fixes knative#837
knative-prow-robot pushed a commit that referenced this issue Sep 13, 2018
@markusthoemmes @knative-prow-robot
Allow the activator to deal with multiple service ports. (#1915)
cfca0cd 
* Allow the activator to deal with multiple service ports.

The activator today assumes that a service has exactly one port. An unnecessary restriction.

This exposes a well-known port per service and allows the activator to deal with an arbitrary number of ports on the service side as long as the well-known port exists at least.

Fixes #837

* Fix merge mistake.
nak3 pushed a commit to nak3/serving that referenced this issue Jul 13, 2021
@markusthoemmes
Use images as built onto the environment (knative#837)
16971c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@markusthoemmes @akyyy @google-prow-robot