Bump autoscaler resources to be equal to controller resources #10865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The autoscaler is a controller of a few resources after all and it's doing a lot more work asynchronously too.
knative-prow-robot
added
the
size/XS
Codecov Report
@@ Coverage Diff @@
## master #10865 +/- ##
==========================================
+ Coverage 87.96% 88.02% +0.05%
==========================================
Files 188 188
Lines 9102 9102
==========================================
+ Hits 8007 8012 +5
+ Misses 837 835 -2
+ Partials 258 255 -3
Continue to review full report at Codecov.
|
vagababov
reviewed
Mar 1, 2021
knative-prow-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/unhold nobody complained :) |
knative-prow-robot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The autoscaler is a controller of a few resources after all and it's doing a lot more work asynchronously too. We've (Red Hat Openshift Serverless) been seeing quite a lot of CPU throttling in the autoscaler and the limits and requests seem indeed to be fairly low given the work the autoscaler is doing. This aligns the resources with the controller but we surely need a better way to set these values and/or communicate what the expected amount of handled resources can be.
Release Note
/assign @julz @vagababov