Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add subresource to our types via patch to support K8s 1.22 #11812

Closed
wants to merge 1 commit into from
Closed

[WIP] Add subresource to our types via patch to support K8s 1.22 #11812

wants to merge 1 commit into from

Conversation

markusthoemmes
Copy link
Contributor

@markusthoemmes markusthoemmes commented Aug 17, 2021 •
edited
Loading

A potential fix for #11805 (and #11448)

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 17, 2021
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 17, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021 •
edited
Loading

Codecov Report

Merging #11812 (b68c396) into main (6a54ed8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11812      +/-   ##
==========================================
- Coverage   87.84%   87.83%   -0.02%     
==========================================
  Files         196      196              
  Lines        9394     9394              
==========================================
- Hits         8252     8251       -1     
  Misses        888      888              
- Partials      254      255       +1
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 84.61% <0.00%> (-2.31%) ⬇️
pkg/autoscaler/statforwarder/leases.go 76.97% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a54ed8...b68c396. Read the comment docs.

julz
julz reviewed Aug 17, 2021
View reviewed changes
Copy link
Member

@julz julz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't hate this approach, although I guess it's a little sad that Tekton etc would presumably need a similar temporary hack (though they'd also need to bump for a cherry pick eventually so not a huge difference). May well be the simplest temporary fix till we can get a proper cherry pick, or our support policies let us bump to 1.22+ 🤷.

cc @dprotaso @imjasonh

.github/workflows/kind-e2e.yaml
- v1.21.1
#- v1.19.11
#- v1.20.7
#- v1.21.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't want to leave this in :) (commenting to make sure we don't forget)

@markusthoemmes
Copy link
Contributor Author

This has served it's showcasing duty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julz julz julz left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markusthoemmes @knative-prow-robot @julz