Allow probes to explicitly set the port to the containerPort (#8288)

[evankanderson]

Fixes #8288

Proposed Changes

• Accept specs which specify an explicit probe on the containerPort.
  • Baseline Kubernetes does not permit TCP / HTTP probes without a port specified. Requiring these to be unset makes it hard to build generic tools for both k8s Deployment/etc and Knative, and seems overly restrictive.

Release Note

Allow setting TCP and HTTP port to be equal to containerPort on readiness and liveness probes.

[codecov]

Codecov Report

Merging #12225 (00e2b4f) into main (cad72a3) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #12225      +/-   ##
==========================================
- Coverage   87.36%   87.32%   -0.05%     
==========================================
  Files         196      195       -1     
  Lines        9611     9583      -28     
==========================================
- Hits         8397     8368      -29     
- Misses        935      936       +1     
  Partials      279      279              

Impacted Files	Coverage Δ
pkg/apis/serving/fieldmask.go	95.07% <100.00%> (+0.03%)	⬆️
pkg/apis/serving/k8s_validation.go	93.50% <100.00%> (+0.19%)	⬆️
pkg/autoscaler/scaling/multiscaler.go	87.27% <0.00%> (-1.82%)	⬇️
pkg/queue/health/handler.go	100.00% <0.00%> (ø)
pkg/queue/health/health_state.go
cmd/queue/main.go	0.49% <0.00%> (+<0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad72a3...00e2b4f. Read the comment docs.

[julz]

elsewhere (1, 2) where we've returned a value as well as the field error in validation we've kept to the convention of the err being last (even though it's a slightly special err type), probably worth staying consistent

[evankanderson]

Thanks. I'll admit that I sort of just got annoyed and skipped a bunch of other stuff I was doing yesterday when I realized that I'd bumped this bug but hadn't actually made sure it got fixed.

[julz]

fwiw I got a bit confused about this use of IntOrString because we're really using it as an IntAndString here I think (which is a bit at odds with the Type field in IntOrString and some of its methods). What do you think about returning the matched ContainerPort struct instead (and then we could use the explicit Name and ContainerPort fields in validateProbe)?

[evankanderson]

/shrug

Sure, why not.

[evankanderson]

Ready for another look

[julz]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, julz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [evankanderson,julz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/cherry-pick release-1.0

[knative-prow-robot]

@dprotaso: new pull request created: #12270

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.