Hpa stabilization window

[enoodle]

The default stabilization window for HPA is 300s and can be set to different values. The meaning of this window is very similar to the KPA window, so we can use the same annotation.

Proposed Changes

• Set HPA stabilization window from autoscaling window annotation

Release Note

HPA autoscaler stabilization window can be set from autoscaling window annotation

[knative-prow-robot]

Hi @enoodle. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[markusthoemmes]

/ok-to-test

Thanks for breaking these up!

[codecov]

Codecov Report

Merging #12286 (381f1de) into main (532231b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #12286      +/-   ##
==========================================
- Coverage   87.33%   87.30%   -0.04%     
==========================================
  Files         195      195              
  Lines        9610     9616       +6     
==========================================
+ Hits         8393     8395       +2     
- Misses        937      940       +3     
- Partials      280      281       +1     

Impacted Files	Coverage Δ
pkg/apis/autoscaling/annotation_validation.go	100.00% <ø> (ø)
pkg/reconciler/autoscaling/hpa/resources/hpa.go	100.00% <100.00%> (ø)
pkg/autoscaler/scaling/multiscaler.go	87.27% <0.00%> (-1.82%)	⬇️
pkg/reconciler/configuration/configuration.go	84.61% <0.00%> (-1.54%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532231b...381f1de. Read the comment docs.

[psschwei]

/lgtm

[nader-ziada]

lgtm

[nader-ziada]

I believe this is ready to be approved

[markusthoemmes]

/lgtm
/approve

@enoodle Thanks for this! Could you send a PR to knative/docs to add this new setting to the HPA?

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enoodle, markusthoemmes, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/autoscaling/OWNERS [markusthoemmes]
• pkg/reconciler/autoscaling/OWNERS [markusthoemmes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment