Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.1] Reduce the period and failure threshold for activator readiness #12619

Merged
merged 1 commit into from
Feb 13, 2022
Merged

[release-1.1] Reduce the period and failure threshold for activator readiness #12619

merged 1 commit into from
Feb 13, 2022

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #12614

NONE

@dprotaso @knative-prow-robot
Reduce the period and failure threshold for activator readiness
9f95583 
The default drain timeout is 45 seconds which was much shorter than
the time it takes the activator to be recognized as not ready (2 minutes)

This was resulting in 503s since the activator was receiving traffic when it
was not expecting it
@knative-prow-robot knative-prow-robot mentioned this pull request Feb 13, 2022
Merged
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 13, 2022
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2022
@knative-prow-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2022
@codecov
Copy link

codecov bot commented Feb 13, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-1.1@e9a0b77). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-1.1   #12619   +/-   ##
==============================================
  Coverage               ?   87.39%           
==============================================
  Files                  ?      195           
  Lines                  ?     9646           
  Branches               ?        0           
==============================================
  Hits                   ?     8430           
  Misses                 ?      931           
  Partials               ?      285

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a0b77...9f95583. Read the comment docs.

@dprotaso dprotaso mentioned this pull request Feb 13, 2022
Merged
@dprotaso
Copy link
Member

/override pull-knative-serving-istio-latest-no-mesh

@knative-prow-robot
Copy link
Contributor Author

@dprotaso: Overrode contexts on behalf of dprotaso: pull-knative-serving-istio-latest-no-mesh

In response to this:

/override pull-knative-serving-istio-latest-no-mesh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot merged commit a3fd18a into knative:release-1.1 Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knative-prow-robot @dprotaso