Remove the scale-to-zero checking in conformance. #13025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
size/S
Codecov Report
@@ Coverage Diff @@
## main #13025 +/- ##
==========================================
- Coverage 87.03% 87.00% -0.04%
==========================================
Files 197 197
Lines 14439 14439
==========================================
- Hits 12567 12562 -5
- Misses 1578 1582 +4
- Partials 294 295 +1
Continue to review full report at Codecov.
|
Conformance should be a measurement of the Knative API and runtime semantics, not the details of how those semantics are implemented. Scaling to zero is effectively a cost optimization, but should not be a requirement of a conforming implementation. For instance, if I were to set `min-scale: "1"` cluster-wide, I should still have a conformant implementation, since the key semantics of the API are still preserved.
mattmoor
force-pushed
the
remove-scale-to-zero-check
branch
from
2cc97c8
to
b064aae
Compare
knative-prow
bot
added
size/M
psschwei
reviewed
Jun 13, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conformance should be a measurement of the Knative API and runtime semantics, not the details of how those semantics are implemented. Scaling to zero is effectively a cost optimization, but should not be a requirement of a
conforming implementation.
For instance, if I were to set
min-scale: "1"cluster-wide, I should still have a conformant implementation, since the key semantics of the API are still preserved.Release Note