-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ubuntu 20.04 for kind e2e tests #13528
Conversation
Signed-off-by: Paul S. Schweigert <[email protected]> Github recently made the `ubuntu-latest` runner label refer to Ubuntu 22.04 (before it had been 20.04). 22.04 uses cgroups v2 by default, whereas 20.04 was still using cgroups v1. It seems that our cgroups conformance tests were written for cgroups v1, as they fail when using cgroups v2 (tested on both Ubuntu 22.04 and Fedora 36). As a short-term solution, this patch will keep running the e2e tests on Ubuntu 20.04, until we have a chance to rewrite the conformance tests to work with cgroups v2.
Codecov ReportBase: 86.43% // Head: 86.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #13528 +/- ##
==========================================
+ Coverage 86.43% 86.45% +0.02%
==========================================
Files 196 196
Lines 14600 14600
==========================================
+ Hits 12619 12622 +3
+ Misses 1680 1678 -2
+ Partials 301 300 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
/assign @dprotaso |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.8 |
/cherry-pick release-1.7 |
/cherry-pick release-1.6 |
@dprotaso: new pull request created: #13540 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dprotaso: new pull request created: #13541 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dprotaso: #13528 failed to apply on top of branch "release-1.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* cherry pick #13528 * set ubuntu-20.04 on all jobs
Signed-off-by: Paul S. Schweigert [email protected]
Github recently made the
ubuntu-latest
runner label refer to Ubuntu 22.04 (before it had been 20.04). 22.04 uses cgroups v2 by default, whereas 20.04 was still using cgroups v1.It seems that our cgroups conformance tests were written for cgroups v1, as they fail when using cgroups v2 (tested on both Ubuntu 22.04 and Fedora 36).
As a short-term solution, this patch will keep running the e2e tests on Ubuntu 20.04, until we have a chance to rewrite the conformance tests to work with cgroups v2.