Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu 20.04 for kind e2e tests #13528

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Conversation

psschwei
Copy link
Contributor

@psschwei psschwei commented Dec 2, 2022

Signed-off-by: Paul S. Schweigert [email protected]

Github recently made the ubuntu-latest runner label refer to Ubuntu 22.04 (before it had been 20.04). 22.04 uses cgroups v2 by default, whereas 20.04 was still using cgroups v1.

It seems that our cgroups conformance tests were written for cgroups v1, as they fail when using cgroups v2 (tested on both Ubuntu 22.04 and Fedora 36).

As a short-term solution, this patch will keep running the e2e tests on Ubuntu 20.04, until we have a chance to rewrite the conformance tests to work with cgroups v2.

Signed-off-by: Paul S. Schweigert <[email protected]>

Github recently made the `ubuntu-latest` runner label refer to Ubuntu
22.04 (before it had been 20.04). 22.04 uses cgroups v2 by default,
whereas 20.04 was still using cgroups v1.

It seems that our cgroups conformance tests were written for cgroups
v1, as they fail when using cgroups v2 (tested on both Ubuntu 22.04
and Fedora 36).

As a short-term solution, this patch will keep running the e2e tests
on Ubuntu 20.04, until we have a chance to rewrite the conformance
tests to work with cgroups v2.
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 2, 2022
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 86.43% // Head: 86.45% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (ab21068) compared to base (327bf91).
Patch has no changes to coverable lines.

❗ Current head ab21068 differs from pull request most recent head ac3371c. Consider uploading reports for the commit ac3371c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13528      +/-   ##
==========================================
+ Coverage   86.43%   86.45%   +0.02%     
==========================================
  Files         196      196              
  Lines       14600    14600              
==========================================
+ Hits        12619    12622       +3     
+ Misses       1680     1678       -2     
+ Partials      301      300       -1     
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 84.36% <0.00%> (+1.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Paul S. Schweigert <[email protected]>
@psschwei psschwei changed the title [WIP] Use ubuntu 20.04 for kind e2e tests Use ubuntu 20.04 for kind e2e tests Dec 2, 2022
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2022
@psschwei
Copy link
Contributor Author

psschwei commented Dec 2, 2022

/assign @dprotaso

@dprotaso
Copy link
Member

dprotaso commented Dec 5, 2022

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@knative-prow
Copy link

knative-prow bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7f217bb into knative:main Dec 5, 2022
@dprotaso
Copy link
Member

dprotaso commented Dec 8, 2022

/cherry-pick release-1.8

@dprotaso
Copy link
Member

dprotaso commented Dec 8, 2022

/cherry-pick release-1.7

@dprotaso
Copy link
Member

dprotaso commented Dec 8, 2022

/cherry-pick release-1.6

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #13540

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #13541

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@dprotaso: #13528 failed to apply on top of branch "release-1.6":

Applying: use ubuntu 20.04 for kind e2e tests
Applying: check cgroup version
Applying: actually run the tests on 20.04 with go 1.19
Using index info to reconstruct a base tree...
M	.github/workflows/kind-e2e.yaml
Falling back to patching base and 3-way merge...
Auto-merging .github/workflows/kind-e2e.yaml
CONFLICT (content): Merge conflict in .github/workflows/kind-e2e.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 actually run the tests on 20.04 with go 1.19
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dprotaso added a commit to dprotaso/serving that referenced this pull request Dec 8, 2022
knative-prow bot pushed a commit that referenced this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants