Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.12] Don't drop traffic when upgrading a deployment fails #14840

Merged
merged 5 commits into from
Feb 2, 2024
Merged

[release-1.12] Don't drop traffic when upgrading a deployment fails #14840

merged 5 commits into from
Feb 2, 2024

Commits on Jan 30, 2024

  1. Surface Replica failures over Progressing failures 

    When transforming the deployment status to the revision
we want to bubble up the more severe condition to Ready.

Since Replica failures will include a more actionable error
message this condition is preferred
    @dprotaso
    dprotaso committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    896233b View commit details
    Browse the repository at this point in the history

  2. Stop always marking the revision healthy when the PA is Ready 

    This isn't accurate when the Revision has failed to rollout
an update to it's deployment
    @dprotaso
    dprotaso committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3bb86a0 View commit details
    Browse the repository at this point in the history

  3. Various updates to the revision reconciler 

    1. PA Reachability now depends on the status of the Deployment

If we have available replicas we don't mark the revision as
unreachable. This allows ongoing requests to be handled

2. Always propagate the K8s Deployment Status to the Revision.

We don't need to gate this depending on whether the Revision
required activation. Since the only two conditions we propagate
from the Deployment is Progressing and ReplicaSetFailure=False

3. Mark Revision as Deploying if the PA's service name isn't set
    @dprotaso
    dprotaso committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5d6068f View commit details
    Browse the repository at this point in the history

  4. test deployment failures don't drop traffic on upgrade

    @dprotaso
    dprotaso committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    fecc0a0 View commit details
    Browse the repository at this point in the history

  5. fix boilerplate check

    @dprotaso
    dprotaso committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    f50114f View commit details
    Browse the repository at this point in the history