[release-1.13] Don't drop traffic when upgrading a deployment fails #14864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When transforming the deployment status to the revision we want to bubble up the more severe condition to Ready. Since Replica failures will include a more actionable error message this condition is preferred
This isn't accurate when the Revision has failed to rollout an update to it's deployment
1. PA Reachability now depends on the status of the Deployment If we have available replicas we don't mark the revision as unreachable. This allows ongoing requests to be handled 2. Always propagate the K8s Deployment Status to the Revision. We don't need to gate this depending on whether the Revision required activation. Since the only two conditions we propagate from the Deployment is Progressing and ReplicaSetFailure=False 3. Mark Revision as Deploying if the PA's service name isn't set
knative-prow
bot
added
area/autoscale
area/test-and-release
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-1.13 #14864 +/- ##
================================================
- Coverage 85.91% 85.90% -0.02%
================================================
Files 197 197
Lines 14991 15000 +9
================================================
+ Hits 12879 12885 +6
- Misses 1798 1800 +2
- Partials 314 315 +1 ☔ View full report in Codecov by Sentry. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
openshift-merge-bot bot
pushed a commit
to openshift-knative/serving
that referenced
this pull request
Mar 11, 2024
…native#14864) (#655) * Surface Replica failures over Progressing failures When transforming the deployment status to the revision we want to bubble up the more severe condition to Ready. Since Replica failures will include a more actionable error message this condition is preferred * Stop always marking the revision healthy when the PA is Ready This isn't accurate when the Revision has failed to rollout an update to it's deployment * Various updates to the revision reconciler 1. PA Reachability now depends on the status of the Deployment If we have available replicas we don't mark the revision as unreachable. This allows ongoing requests to be handled 2. Always propagate the K8s Deployment Status to the Revision. We don't need to gate this depending on whether the Revision required activation. Since the only two conditions we propagate from the Deployment is Progressing and ReplicaSetFailure=False 3. Mark Revision as Deploying if the PA's service name isn't set * test deployment failures don't drop traffic on upgrade * fix boilerplate check --------- Co-authored-by: Knative Prow Robot <[email protected]> Co-authored-by: dprotaso <[email protected]> Co-authored-by: John Doe <johndoe@localhost>
ReToCode
pushed a commit
to ReToCode/serving
that referenced
this pull request
Mar 27, 2024
…native#14864) (knative#655) * Surface Replica failures over Progressing failures When transforming the deployment status to the revision we want to bubble up the more severe condition to Ready. Since Replica failures will include a more actionable error message this condition is preferred * Stop always marking the revision healthy when the PA is Ready This isn't accurate when the Revision has failed to rollout an update to it's deployment * Various updates to the revision reconciler 1. PA Reachability now depends on the status of the Deployment If we have available replicas we don't mark the revision as unreachable. This allows ongoing requests to be handled 2. Always propagate the K8s Deployment Status to the Revision. We don't need to gate this depending on whether the Revision required activation. Since the only two conditions we propagate from the Deployment is Progressing and ReplicaSetFailure=False 3. Mark Revision as Deploying if the PA's service name isn't set * test deployment failures don't drop traffic on upgrade * fix boilerplate check --------- Co-authored-by: Knative Prow Robot <[email protected]> Co-authored-by: dprotaso <[email protected]> Co-authored-by: John Doe <johndoe@localhost>
openshift-merge-bot bot
pushed a commit
to openshift-knative/serving
that referenced
this pull request
Mar 27, 2024
…native#14864) (#655) (#675) * Surface Replica failures over Progressing failures When transforming the deployment status to the revision we want to bubble up the more severe condition to Ready. Since Replica failures will include a more actionable error message this condition is preferred * Stop always marking the revision healthy when the PA is Ready This isn't accurate when the Revision has failed to rollout an update to it's deployment * Various updates to the revision reconciler 1. PA Reachability now depends on the status of the Deployment If we have available replicas we don't mark the revision as unreachable. This allows ongoing requests to be handled 2. Always propagate the K8s Deployment Status to the Revision. We don't need to gate this depending on whether the Revision required activation. Since the only two conditions we propagate from the Deployment is Progressing and ReplicaSetFailure=False 3. Mark Revision as Deploying if the PA's service name isn't set * test deployment failures don't drop traffic on upgrade * fix boilerplate check --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Knative Prow Robot <[email protected]> Co-authored-by: dprotaso <[email protected]> Co-authored-by: John Doe <johndoe@localhost>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #14840
Part of #14795
Depends on 1.12 point release with the following fix - #14840