Drop unused OWNER files and drop productivity folks from being tagged for review #15051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
approved
knative-prow
bot
added
area/monitoring
area/networking
area/test-and-release
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15051 +/- ##
==========================================
- Coverage 84.04% 84.04% -0.01%
==========================================
Files 213 213
Lines 16796 16796
==========================================
- Hits 14117 14116 -1
- Misses 2325 2326 +1
Partials 354 354 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the OWNER files
A lot of them were adding labels to different PRs - this was used previously to segment code into different WG areas (eg. scaling, networking). This isn't needed anymore.
The second bit is changes in the folder
hackandtestproductivity reviewers were being tagged which isn't correct anymore since serving is responsible for this. A ways back this was a productivity concern when they 'owned' the tests (back in '18-19)