-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable kourier-tls #15053
disable kourier-tls #15053
Conversation
/assign @ReToCode |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15053 +/- ##
=======================================
Coverage 84.08% 84.09%
=======================================
Files 213 213
Lines 16776 16776
=======================================
+ Hits 14106 14107 +1
Misses 2318 2318
+ Partials 352 351 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit 8bda840.
This reverts commit 8bda840.
This reverts commit 8bda840.
This reverts commit 8bda840.
This reverts commit 8bda840.
This reverts commit 8bda840.
This reverts commit 8bda840.
This reverts commit 8bda840.
This reverts commit 8bda840.
This reverts commit 8bda840.
* integrate net-certmanager in Serving * Revert "disable kourier-tls (#15053)" This reverts commit 8bda840. * fix imports * add netcert conformance tests * fix vendor * add vendor networking test files * some fixes + rebase * fixes * add crd check * sym link * fix vendor * move reconciler * fix style * empty * move to pkg/client
* integrate net-certmanager in Serving * Revert "disable kourier-tls (knative#15053)" This reverts commit 8bda840. * fix imports * add netcert conformance tests * fix vendor * add vendor networking test files * some fixes + rebase * fixes * add crd check * sym link * fix vendor * move reconciler * fix style * empty * move to pkg/client (cherry picked from commit 6ccb82f)
* Integrate net-certmanager in Serving (knative#15066) * integrate net-certmanager in Serving * Revert "disable kourier-tls (knative#15053)" This reverts commit 8bda840. * fix imports * add netcert conformance tests * fix vendor * add vendor networking test files * some fixes + rebase * fixes * add crd check * sym link * fix vendor * move reconciler * fix style * empty * move to pkg/client (cherry picked from commit 6ccb82f) * Run `openshift/release/generate-release.sh release-v1.14` --------- Co-authored-by: Stavros Kontopoulos <[email protected]>
It's very flaky - disabling for now until we can sort out the issues
tracking issue: #15052