Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable kourier-tls #15053

Merged
merged 1 commit into from
Mar 28, 2024
Merged

disable kourier-tls #15053

merged 1 commit into from
Mar 28, 2024

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Mar 27, 2024

It's very flaky - disabling for now until we can sort out the issues

tracking issue: #15052

@knative-prow knative-prow bot requested review from izabelacg and skonto March 27, 2024 21:34
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 27, 2024
@dprotaso
Copy link
Member Author

/assign @ReToCode

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base (315a94c) to head (1012f11).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15053   +/-   ##
=======================================
  Coverage   84.08%   84.09%           
=======================================
  Files         213      213           
  Lines       16776    16776           
=======================================
+ Hits        14106    14107    +1     
  Misses       2318     2318           
+ Partials      352      351    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
Copy link

knative-prow bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8bda840 into knative:main Mar 28, 2024
45 checks passed
ReToCode added a commit to ReToCode/serving that referenced this pull request Mar 28, 2024
skonto added a commit to skonto/serving that referenced this pull request Mar 29, 2024
skonto added a commit to skonto/serving that referenced this pull request Mar 29, 2024
skonto added a commit to skonto/serving that referenced this pull request Apr 3, 2024
skonto added a commit to skonto/serving that referenced this pull request Apr 4, 2024
skonto added a commit to skonto/serving that referenced this pull request Apr 5, 2024
skonto added a commit to skonto/serving that referenced this pull request Apr 11, 2024
skonto added a commit to skonto/serving that referenced this pull request Apr 11, 2024
skonto added a commit to skonto/serving that referenced this pull request Apr 22, 2024
skonto added a commit to skonto/serving that referenced this pull request Apr 24, 2024
knative-prow bot pushed a commit that referenced this pull request Apr 25, 2024
* integrate net-certmanager in Serving

* Revert "disable kourier-tls (#15053)"

This reverts commit 8bda840.

* fix imports

* add netcert conformance tests

* fix vendor

* add vendor networking test files

* some fixes + rebase

* fixes

* add crd check

* sym link

* fix vendor

* move reconciler

* fix style

* empty

* move to pkg/client
ReToCode pushed a commit to ReToCode/serving that referenced this pull request Apr 29, 2024
* integrate net-certmanager in Serving

* Revert "disable kourier-tls (knative#15053)"

This reverts commit 8bda840.

* fix imports

* add netcert conformance tests

* fix vendor

* add vendor networking test files

* some fixes + rebase

* fixes

* add crd check

* sym link

* fix vendor

* move reconciler

* fix style

* empty

* move to pkg/client

(cherry picked from commit 6ccb82f)
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request May 1, 2024
* Integrate net-certmanager in Serving (knative#15066)

* integrate net-certmanager in Serving

* Revert "disable kourier-tls (knative#15053)"

This reverts commit 8bda840.

* fix imports

* add netcert conformance tests

* fix vendor

* add vendor networking test files

* some fixes + rebase

* fixes

* add crd check

* sym link

* fix vendor

* move reconciler

* fix style

* empty

* move to pkg/client

(cherry picked from commit 6ccb82f)

* Run `openshift/release/generate-release.sh release-v1.14`

---------

Co-authored-by: Stavros Kontopoulos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants