Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove certmanager integration tests #15261

Merged
merged 11 commits into from
May 28, 2024
Merged

Remove certmanager integration tests #15261

merged 11 commits into from
May 28, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented May 27, 2024 •
edited
Loading

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2024
@knative-prow knative-prow bot requested review from izabelacg and ReToCode May 27, 2024 18:54
@codecov Codecov
Copy link

codecov bot commented May 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (b15ce9a) to head (1ac5bff).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #15261   +/-   ##
=======================================
  Coverage   84.76%   84.76%           
=======================================
  Files         218      218           
  Lines       13479    13479           
=======================================
+ Hits        11425    11426    +1     
- Misses       1686     1687    +1     
+ Partials      368      366    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2024
@skonto skonto changed the title [wip] Fix typo in certmanager tests [wip] Fix certmanager integration tests May 27, 2024
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2024
@skonto
Copy link
Contributor Author

skonto commented May 28, 2024

/assign @ReToCode

@skonto skonto changed the title [wip] Fix certmanager integration tests Fix certmanager integration tests May 28, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2024
@skonto
Copy link
Contributor Author

skonto commented May 28, 2024 •
edited
Loading

Next steps:

  • update the knative/infra config to point to the top presubmit script
  • remove the local presubmit script
  • move tests in the top e2e-tests.sh, do we want to test with these signers end-to-end or just check if secrets are created?

@ReToCode
Copy link
Member

Hm, can we just run them on "Serving"? I don't think we need a separate job that runs the "same" as we already have in Serving. Or am I missing something?

@skonto
Copy link
Contributor Author

skonto commented May 28, 2024 •
edited
Loading

Hm, can we just run them on "Serving"?

That will happen after the clean up, I don't plan to run them in a separate one but I want also to understand if we are going to test with those signers or not (we will run only with the ca one?). I want also to make sure tests are running ok first. I will do the follow up PRs.

skonto
skonto commented May 28, 2024
View reviewed changes
test/e2e/certmanager/e2e-tests.sh Outdated
add_trap "kubectl delete -f ./test/e2e/certmanager/config/autotls/certmanager/http01/ --ignore-not-found" SIGKILL SIGTERM SIGQUIT
go_test_e2e -timeout=10m ./test/e2e/certmanager/conformance \
-run TestHTTP01Conformance \
"--certificateClass=${CERTIFICATE_CLASS}" || fail_test
kubectl delete -f ./test/e2e/certmanager/config/autotls/certmanager/http01/
kubectl delete -f "${E2E_YAML_DIR}"/test/config/externaldomaintls/certmanager/http01/
Copy link
Contributor Author

@skonto skonto May 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both mesh and the other issuer for http01? cc @ReToCode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mesh? Each test has its own issuer, if this is what you are asking?

Copy link
Contributor Author

@skonto skonto May 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two files https://github.com/knative-extensions/net-certmanager/blob/main/test/config/autotls/certmanager/http01/issuer.yaml
https://github.com/knative-extensions/net-certmanager/blob/main/test/config/autotls/certmanager/http01/mesh-issuer.yaml
When we apply the resources under http01 dir both are applied should we merge?
Although tests pass I see:

Error from server (NotFound): error when deleting "/tmp/knative.aB6zlpVa/ci-2024-05-27-21-25-25-2PDN6eysqT/e2e-yaml/test/config/externaldomaintls/certmanager/http01/mesh-issuer.yaml": clusterissuers.cert-manager.io "http01-issuer" not found

@ReToCode ReToCode mentioned this pull request May 28, 2024
Merged
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@skonto skonto mentioned this pull request May 28, 2024
Closed
@skonto
Copy link
Contributor Author

skonto commented May 28, 2024

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@skonto
Copy link
Contributor Author

skonto commented May 28, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@skonto
Copy link
Contributor Author

skonto commented May 28, 2024

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@skonto skonto mentioned this pull request May 28, 2024
Merged
@skonto
Copy link
Contributor Author

skonto commented May 28, 2024 •
edited
Loading

Holding for knative/infra#447, then I will remove the tests here. cc @dprotaso
I could also override them.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@skonto skonto changed the title Fix certmanager integration tests Remove certmanager integration tests May 28, 2024
@skonto
Copy link
Contributor Author

skonto commented May 28, 2024

@dprotaso or @ReToCode pls review

@dprotaso
Copy link
Member

you'll have to run codegen - some stuff in vendor will be pruned

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2024
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 28, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2024
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@knative-prow knative-prow bot merged commit 4fe029f into knative:main May 28, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izabelacg izabelacg Awaiting requested review from izabelacg

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees

@dprotaso dprotaso

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up certmanager conformance tests
4 participants
@skonto @ReToCode @dprotaso @knative-prow-robot