-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ipv6 address for sslip.io in default-domain Job #15328
Conversation
Signed-off-by: Nghia Tran <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15328 +/- ##
==========================================
- Coverage 84.75% 84.74% -0.01%
==========================================
Files 218 218
Lines 13504 13508 +4
==========================================
+ Hits 11445 11448 +3
+ Misses 1692 1690 -2
- Partials 367 370 +3 ☔ View full report in Codecov by Sentry. |
It runs ok for ip4, run it locally. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes
Release Note